-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtual environment activation is broken #22910
Comments
Thanks for reporting @ababak , can you switch to pre-release as stated and then provide the logs? |
Also, it seems like you're using still using "Git bash" based on the logs, please provide logs after switching shell either to Cmd or Powershell using |
Sure thing. Here is the requested log.
|
That's weird. It looks like the pre-release version is activating the environment now. At least for PowerShell. |
I published a new pre-release with a potential fix: #22905, well glad to know it helps. If it re-occurs feel free to let us know and we'll be happy to reopen and take a look. |
Now it does work for GitBash only when it's not a default shell:
And now after setting GitBash as the default shell (note
|
Is there a chance that despite Git Bash not being officially supported, it could still be fixed when it is set as the default shell? ;) |
I'll try to look into it, but right now we're swarmed with issues for other supported shell so we don't have the bandwidth yet. |
Not everybody, unfortunately, has the luxury to spawn WSL in corporate environments, which means we're forced to use |
@karrtikr I tried installing the pre-release version of the extension and I tried setting the default profile as Powershell. I tried restarting my VS Code and I tried opening up a second Powershell prompt after it VSCode started up and the first prompt was shown. In all situations the virtual enviornment failed to activate. |
Ok please create a new issue this time providing the debug level logs for Powershell and we'll be happy to look into what's going on. Make sure to also include the screenshots asked. |
I have the same problem with the pre-release extension, Git Bash works properly only when it's not set as the default prompt. I looked at the logs in the last @ababak post and I think I see a possible culprit for the bug: they have their repo on /d/ instead of /c/ (same as me), and in the working scenario the path is added like so:
but in the broken scenario the path is wrong:
It's like this for me as well. @karrtikr could this be the problem? edit: Yeah that's definitely it, I tried again with a repo on /c/ and Git Bash as the default terminal and it worked. Something's broken with path handling to the current repo. |
Type: Bug
Behaviour
Expected vs. Actual
I encounter a messed up
PATH
variable that causes significant issues. TheVSCODE_ENV_PREPEND
variable already contains incorrect data.Related to: #22908
Steps to reproduce:
Diagnostic data
python.languageServer
setting: DefaultOutput for
Python
in theOutput
panel (View
→Output
, change the drop-down the upper-right of theOutput
panel toPython
)User Settings
Extension version: 2024.0.1
VS Code version: Code 1.86.1 (31c37ee8f63491495ac49e43b8544550fbae4533, 2024-02-07T09:08:20.941Z)
OS version: Windows_NT x64 10.0.22631
Modes:
System Info
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
A/B Experiments
The text was updated successfully, but these errors were encountered: