Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Revisit the LanguageServerDownloader class and redesign for DI and more general use cases. #2421

Closed
d3r3kk opened this issue Aug 21, 2018 · 3 comments
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@d3r3kk
Copy link

d3r3kk commented Aug 21, 2018

Our current class for downloading the Language Server is one that was made-for-purpose and as such has a bit of an anti-pattern design for what we would like for the extension overall.

Discuss improving upon the current implementation to make it easier to re-use for future cases where we may need to download extra libs/interpreters/etc.

Discussion should also include cost/benefit of redesigning the current implementation to incorporate DI, and to improve test-ability.

@MikhailArkhipov
Copy link

IMO we can redesign it when it comes to downloading something else.

@brettcannon brettcannon added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. feature-* labels Aug 21, 2018
@DonJayamanne
Copy link

IMO we can redesign it when it comes to downloading something else.

Agreed.

@brettcannon
Copy link
Member

We can rewrite it when there's a need to (e.g. testing needs or another use).

@lock lock bot locked as resolved and limited conversation to collaborators Oct 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Development

No branches or pull requests

4 participants