Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporally disable Terminal REPL shell integration for Python3.13 #24339

Closed
anthonykim1 opened this issue Oct 28, 2024 · 1 comment · Fixed by #24341
Closed

Temporally disable Terminal REPL shell integration for Python3.13 #24339

anthonykim1 opened this issue Oct 28, 2024 · 1 comment · Fixed by #24341
Assignees
@anthonykim1
Labels
area-repl area-terminal bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested verified Verification succeeded
Milestone
November 2024

Comments

@anthonykim1
Copy link

Related: microsoft/vscode#232420
Before getting upstream fix in from cpython, we should temporally disable shell integration in Python terminal REPL as it leads to awkward cursor positioning in user's Python terminal REPL>
@anthonykim1 anthonykim1 added area-repl area-terminal bug Issue identified by VS Code Team member as probable bug labels Oct 28, 2024
@anthonykim1 anthonykim1 added this to the November 2024 milestone Oct 28, 2024
@anthonykim1 anthonykim1 self-assigned this Oct 28, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 28, 2024
@anthonykim1 anthonykim1 mentioned this issue Oct 28, 2024
Merged
@anthonykim1
Copy link
Author

Verification steps:

  1. Make sure you have Python3.13 installed on your local machine
  2. Install pre-release version of Python extension
  3. type 'python' or other way to trigger your python3.13 executable in terminal
  4. Make sure you dont see signs of shell integration in terminal Python REPL (such as blue or red decorations).

@anthonykim1 anthonykim1 added verification-needed Verification of issue is requested and removed triage-needed Needs assignment to the proper sub-team labels Dec 2, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonykim1 anthonykim1

Labels
area-repl area-terminal bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
November 2024
Development

Successfully merging a pull request may close this issue.

disable shell integration for 3.13 anthonykim1/vscode-python
2 participants
@rzhao271 @anthonykim1