Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discovery API must support additional switches (such as -k=test_ for pytest). #4738

Closed
d3r3kk opened this issue Mar 13, 2019 · 2 comments
Closed
Assignees
Labels
area-testing bug Issue identified by VS Code Team member as probable bug

Comments

@d3r3kk
Copy link

d3r3kk commented Mar 13, 2019

Our new test discovery API must support extra switches that our users will want to configure their test platform with.

For example, the -k=[pattern] switch that tells Pytest what to look for as test identifier.

@d3r3kk d3r3kk added bug Issue identified by VS Code Team member as probable bug needs PR area-testing labels Mar 13, 2019
@DonJayamanne
Copy link

DonJayamanne commented Mar 13, 2019

Doesn't this already work? I was expecting the ts code to pass the arguments as is to the python code, if that's not the case then this needs to be done, else its a regression.

There are a number of other arguments that users will add into "python.unitTest.pyTestArgs" that will need to be used when discovering tests.

Just passing all of the arguments that the TS code had should suffice. I was under the impression that is what was being done.

#3911 (comment)
#4033 (comment)

Not doing this will potentially break existing pytests.
This works with the existing code.

/cc @ericsnowcurrently

@DonJayamanne DonJayamanne added the regression Bug didn't exist in a previous release label Mar 13, 2019
@DonJayamanne DonJayamanne removed the regression Bug didn't exist in a previous release label Mar 13, 2019
@DonJayamanne
Copy link

DonJayamanne commented Mar 20, 2019

Closing this as it has been account for, and the existing tests will ensure this does not get missed in #4795

@ghost ghost removed the needs PR label Mar 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants