Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons next to each test item are no longer visible #7586

Closed
karrtikr opened this issue Sep 24, 2019 · 8 comments
Closed

Icons next to each test item are no longer visible #7586

karrtikr opened this issue Sep 24, 2019 · 8 comments
Assignees
@karrtikr
Labels
area-testing bug Issue identified by VS Code Team member as probable bug regression Bug didn't exist in a previous release
Milestone
2019 - October Sp...

Comments

@karrtikr
Copy link

karrtikr commented Sep 24, 2019 •
edited
Loading

Extension version: 2019.10.38034-dev

image

Icons next to each test item are not visible in the insiders version of the extension.

Steps to reproduce

  1. Choose any test framework and discover tests, see that the icons are not visible.

Logs

User belongs to experiment group 'ShowPlayIcon - start'
User belongs to experiment group 'ShowExtensionSurveyPrompt - enabled'
User belongs to experiment group 'DebugAdapterFactory - experiment'
> conda --version
> pyenv root
> python3.7 -c "import sys;print(sys.executable)"
> python3.6 -c "import sys;print(sys.executable)"
> python3 -c "import sys;print(sys.executable)"
> python2 -c "import sys;print(sys.executable)"
> python -c "import sys;print(sys.executable)"
> py -3.7 -c "import sys;print(sys.executable)"
> py -3.6 -c "import sys;print(sys.executable)"
> py -3 -c "import sys;print(sys.executable)"
> py -2 -c "import sys;print(sys.executable)"
> python -c "import sys;print(sys.executable)"
> ~\AppData\Local\Microsoft\WindowsApps\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Microsoft\WindowsApps\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Microsoft\WindowsApps\python3.7.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Microsoft\WindowsApps\python3.7.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Microsoft\WindowsApps\python3.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Microsoft\WindowsApps\python3.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Programs\Python\Python37\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Programs\Python\Python37\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Programs\Python\Python36\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Programs\Python\Python36\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> conda info --json
> conda env list
> ~\AppData\Local\Programs\Python\Python37\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Programs\Python\Python37\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Programs\Python\Python37\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Programs\Python\Python37\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Programs\Python\Python37\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Programs\Python\Python37\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Programs\Python\Python37\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Programs\Python\Python37\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\.virtualenvs\folder1-8Y_QCwZe\Scripts\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\.virtualenvs\folder1-8Y_QCwZe\Scripts\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> python -m pylint --disable=all --enable=F,unreachable,duplicate-key,unnecessary-semicolon,global-variable-not-assigned,unused-variable,unused-wildcard-import,binary-op-exception,bad-format-string,anomalous-backslash-in-string,bad-open-mode,E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0107,E0108,E0110,E0111,E0112,E0113,E0114,E0115,E0116,E0117,E0118,E0202,E0203,E0211,E0213,E0236,E0237,E0238,E0239,E0240,E0241,E0301,E0302,E0303,E0401,E0402,E0601,E0602,E0603,E0604,E0611,E0632,E0633,E0701,E0702,E0703,E0704,E0710,E0711,E0712,E1003,E1101,E1102,E1111,E1120,E1121,E1123,E1124,E1125,E1126,E1127,E1128,E1129,E1130,E1131,E1132,E1133,E1134,E1135,E1136,E1137,E1138,E1139,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1700,E1701 --msg-template='{line},{column},{category},{symbol}:{msg}' --reports=n --output-format=text c:\Users\karraj\Desktop\memeplex\tests\test_stuff.py
cwd: c:\Users\karraj\Desktop\memeplex
> python -m pylint --disable=all --enable=F,unreachable,duplicate-key,unnecessary-semicolon,global-variable-not-assigned,unused-variable,unused-wildcard-import,binary-op-exception,bad-format-string,anomalous-backslash-in-string,bad-open-mode,E0001,E0011,E0012,E0100,E0101,E0102,E0103,E0104,E0105,E0107,E0108,E0110,E0111,E0112,E0113,E0114,E0115,E0116,E0117,E0118,E0202,E0203,E0211,E0213,E0236,E0237,E0238,E0239,E0240,E0241,E0301,E0302,E0303,E0401,E0402,E0601,E0602,E0603,E0604,E0611,E0632,E0633,E0701,E0702,E0703,E0704,E0710,E0711,E0712,E1003,E1101,E1102,E1111,E1120,E1121,E1123,E1124,E1125,E1126,E1127,E1128,E1129,E1130,E1131,E1132,E1133,E1134,E1135,E1136,E1137,E1138,E1139,E1200,E1201,E1205,E1206,E1300,E1301,E1302,E1303,E1304,E1305,E1306,E1310,E1700,E1701 --msg-template='{line},{column},{category},{symbol}:{msg}' --reports=n --output-format=text c:\Users\karraj\Desktop\memeplex\tests\test_stuff.py
cwd: c:\Users\karraj\Desktop\memeplex
> ~\AppData\Local\Programs\Python\Python36\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Programs\Python\Python36\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Programs\Python\Python37\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> ~\AppData\Local\Programs\Python\Python37\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
> C:\Program Files (x86)\Microsoft Visual Studio\Shared\Python36_64\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\interpreterInfo.py
Starting Jedi Python language engine.
> ~\AppData\Local\Microsoft\WindowsApps\python.exe -c "
import unittest
loader = unittest.TestLoader()
suites = loader.discover("./tests", pattern="*test*.py")
print("start") #Don't remove this line
for suite in suites._tests:
    for cls in suite._tests:
        try:
            for m in cls._tests:
                print(m.id())
        except:
            pass"
cwd: c:\Users\karraj\Desktop\memeplex
> ~\AppData\Local\Microsoft\WindowsApps\python.exe -c "
import unittest
loader = unittest.TestLoader()
suites = loader.discover("./tests", pattern="*test*.py")
print("start") #Don't remove this line
for suite in suites._tests:
    for cls in suite._tests:
        try:
            for m in cls._tests:
                print(m.id())
        except:
            pass"
cwd: c:\Users\karraj\Desktop\memeplex
> conda info --json
> conda --version
> ~\AppData\Local\Microsoft\WindowsApps\python.exe -c "import sys;print(sys.prefix)"
cwd: c:\Users\karraj\Desktop\memeplex
> ~\AppData\Local\Microsoft\WindowsApps\python.exe -c "import sys;print(sys.prefix)"
cwd: c:\Users\karraj\Desktop\memeplex
> ~\AppData\Local\Microsoft\WindowsApps\python.exe -c "import sys;print(sys.executable)"
cwd: c:\Users\karraj\Desktop\memeplex
> ~\AppData\Local\Microsoft\WindowsApps\python.exe -c "import sys;print(sys.executable)"
cwd: c:\Users\karraj\Desktop\memeplex
> ~\AppData\Local\Microsoft\WindowsApps\python.exe -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())"
cwd: c:\Users\karraj\Desktop\memeplex
> ~\AppData\Local\Microsoft\WindowsApps\python.exe -c "from distutils.sysconfig import get_python_lib; print(get_python_lib())"
cwd: c:\Users\karraj\Desktop\memeplex
> ~\AppData\Local\Microsoft\WindowsApps\python.exe -m site --user-site
cwd: c:\Users\karraj\Desktop\memeplex
> ~\AppData\Local\Microsoft\WindowsApps\python.exe -m site --user-site
cwd: c:\Users\karraj\Desktop\memeplex
##########Linting Output - pylint##########

--------------------------------------------------------------------

Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)



> ~\AppData\Local\Microsoft\WindowsApps\python.exe completion.py
cwd: c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles
> ~\AppData\Local\Microsoft\WindowsApps\python.exe completion.py
cwd: c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles
> ~\AppData\Local\Microsoft\WindowsApps\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\visualstudio_py_testlauncher.py --us=./tests --up=*test*.py --uvInt=2 --result-port=62829
cwd: c:\Users\karraj\Desktop\memeplex
> ~\AppData\Local\Microsoft\WindowsApps\python.exe c:\Users\karraj\.vscode-insiders\extensions\ms-python.python-2019.10.38034-dev\pythonFiles\visualstudio_py_testlauncher.py --us=./tests --up=*test*.py --uvInt=2 --result-port=62829
cwd: c:\Users\karraj\Desktop\memeplex
@karrtikr karrtikr added bug Issue identified by VS Code Team member as probable bug needs PR area-testing regression Bug didn't exist in a previous release labels Sep 24, 2019
@karrtikr
Copy link
Author

cc @luabud

@karrtikr
Copy link
Author

karrtikr commented Sep 25, 2019 •
edited
Loading

@ericsnowcurrently Any idea why this might be happening? Probably related to changes regarding #6990.

@luabud
Copy link
Member

luabud commented Sep 25, 2019

@karrtikr does it work with pytest <5.1?

@karrtikr
Copy link
Author

No, it still fails.

@ericsnowcurrently ericsnowcurrently mentioned this issue Sep 26, 2019
Closed
@karrtikr karrtikr mentioned this issue Sep 30, 2019
Closed
@karrtikr
Copy link
Author

Problem was caused by a refactor from https://github.com/microsoft/vscode-python/pull/7263/files

@DonJayamanne DonJayamanne mentioned this issue Sep 30, 2019
Merged
@karrtikr karrtikr assigned karrtikr and unassigned karrtikr Sep 30, 2019
@DonJayamanne
Copy link

FYI - Bug was also caught by the automated UI Tests 😄

@karrtikr
Copy link
Author

karrtikr commented Sep 30, 2019 •
edited
Loading

Great that we have UI tests for such minuscule things 👏

@ghost ghost removed the needs PR label Oct 1, 2019
@karrtikr karrtikr self-assigned this Oct 1, 2019
@karrtikr
Copy link
Author

karrtikr commented Oct 1, 2019

validated

@lock lock bot locked as resolved and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-testing bug Issue identified by VS Code Team member as probable bug regression Bug didn't exist in a previous release
Projects
None yet
Milestone
2019 - October Sprint 1
Development

No branches or pull requests
5 participants
@ericsnowcurrently @DonJayamanne @karthiknadig @karrtikr @luabud