Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor context menu actions feedback #9284

Closed
isidorn opened this issue Dec 24, 2019 · 5 comments
Closed

Editor context menu actions feedback #9284

isidorn opened this issue Dec 24, 2019 · 5 comments
Labels
area-editor-* User-facing catch-all feature-request Request for new features or functionality needs proposal Need to make some design decisions partner ask

Comments

@isidorn
Copy link

isidorn commented Dec 24, 2019

Hi VS Code dev here 👋

Open a python file, invoke a context menu in the editor and notice the following:

  1. Run Current Test File command is there. When I execute it it says that I do not have testing enabled. I suggest to add this command only if testing is enabled in my workspace
  2. Sort Imports -> shouldn't this be a part of the format document. I do not see why this command needs to be so promiment to take space in the context menu. Also there is already Source Action... command which shows the Sort Imports so this feels like duplication.
  3. "Run python file in terminal" and "Run selection line in python terminal". I do not understand why one command says "in terminal" and the other "in python terminal". When I exectute them they just go to the terminal for me. Can we have some consistency in titles, or is it possible to drop one of those actions. Reason being, user can select the whole file and do Run selection, to cover the python file case
  4. Run in Interactive window: I suggest to show this only if I have Jupter or whatever needed setup
  5. Most of these actions do not make sense while you are debugging. I would also consider to hide them while the user is debugging (since the menu grows then additonally with vscode debug commands)

Screenshot 2019-12-24 at 12 48 24

I believe VS Code plans to introduce context sub menus and then python could add all the actions to the submenu potentially.

fyi @qubitron @DonJayamanne

@isidorn isidorn added triage-needed Needs assignment to the proper sub-team feature-request Request for new features or functionality labels Dec 24, 2019
@isidorn
Copy link
Author

isidorn commented Dec 24, 2019

You also show these actions in the Explorer. I think the Explorer should be used for FS operations.

Screenshot 2019-12-24 at 16 06 28

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Dec 30, 2019
@brettcannon
Copy link
Member

Thank you for the suggestion! We have marked this issue as "needs decision" to make sure we have a conversation about your idea. We plan to leave this feature request open for at least a month to see how many 👍 votes the opening comment gets to help us make our decision.

@luabud luabud added needs proposal Need to make some design decisions important Issue identified as high-priority and removed needs decision labels Jan 29, 2020
@luabud luabud self-assigned this Jan 29, 2020
@luabud luabud added important Issue identified as high-priority and removed important Issue identified as high-priority needs proposal Need to make some design decisions labels Feb 27, 2020
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Feb 27, 2020
@luabud luabud added the needs proposal Need to make some design decisions label Feb 27, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Feb 27, 2020
@luabud luabud added partner ask and removed important Issue identified as high-priority labels Mar 30, 2020
@luabud luabud added area-editor-* User-facing catch-all and removed feature-* labels May 13, 2020
@ghost

This comment has been minimized.

@ghost

This comment has been minimized.

@microsoft microsoft locked as too heated and limited conversation to collaborators Apr 5, 2021
@luabud luabud removed their assignment May 12, 2022
@karrtikr
Copy link

We no longer show testing related commands or the selection command in the menu:

image

@karrtikr karrtikr closed this as not planned Won't fix, can't repro, duplicate, stale Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-editor-* User-facing catch-all feature-request Request for new features or functionality needs proposal Need to make some design decisions partner ask
Projects
None yet
Development

No branches or pull requests

5 participants