Don't run "activateEnvironment" command in SSH private terminals

[roblourens]

The Remote-SSH extension starts a hidden remote terminal at one point to run some commands. In this issue microsoft/vscode-remote-release#1760 people reported that the terminal was being shown to them, when it should never be shown because it sets a flag to be hidden. We realized that it is shown because this extension runs a command in it, and setting this setting fixes it:

"python.terminal.activateEnvironment": false

It sounds like the Python extension should be able to know that these terminals are not terminals in the user's workspace, and should not touch them: microsoft/vscode-remote-release#1760 (comment)

[Tyriar]

It looks like the Python extension tries to activate the venv regardless of the type of terminal which should certainly not be happening with the SSH connection ones. microsoft/vscode#63052 was done to help the Python extension know when it should and shouldn't be activating the env so maybe that could be used to avoid activating special terminals like this generally (instead of hardcoding for just the "check remote" terminal)

[lihz6]

This works for me:

    "remote.SSH.enableDynamicForwarding": false

[NellyWhads]

Would a fix like this hit Insiders first? Wondering if I should switch over so I can get this as soon as it's merged/released.

[roblourens]

@karrtikr this seems to be an issue for a lot of people, could this be prioritized?

[karrtikr]

We've started working on it. #9584

[roblourens]

@karrtikr We published 1.42 last week so that new API is available now.

[DonJayamanne]

@karrtikr I've mentioned to @karthiknadig I have a PR for this.
Will push today.

[roblourens]

Thanks! When will the extension next be published?

[karthiknadig]

@roblourens This will be in the next release which will be (like on) March 9th.

[karthiknadig]

@roblourens You can test this out now using the insiders version of the extension (VSIX here).