Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pylance setting and prompt for install if Pylance extension is missing #13123

Merged
merged 36 commits into from
Jul 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
04e0b34
Fix path
May 6, 2020
9297d96
Merge branch 'master' of https://github.com/Microsoft/vscode-python
May 6, 2020
9f3d5ac
Merge branch 'master' of https://github.com/Microsoft/vscode-python
May 11, 2020
607bf98
Merge branch 'master' of https://github.com/Microsoft/vscode-python
Jun 1, 2020
e566214
Merge branch 'master' of https://github.com/Microsoft/vscode-python
Jun 11, 2020
4477900
Actually fix settings
Jun 18, 2020
d0d50de
Add news
Jun 18, 2020
03aa5f9
Add test
Jun 18, 2020
e4a032f
Format
Jun 18, 2020
27eeec7
Suppress 'jediEnabled' removal
Jun 18, 2020
89f432e
Merge branch 'master' of https://github.com/Microsoft/vscode-python
Jun 23, 2020
3ed655b
Drop survey first launch threshold
Jun 26, 2020
64ac38a
Merge branch 'master' of https://github.com/Microsoft/vscode-python
Jun 29, 2020
52a4325
Merge branch 'master' of https://github.com/Microsoft/vscode-python
Jun 30, 2020
67d7cb8
Merge branch 'master' of https://github.com/Microsoft/vscode-python
Jul 8, 2020
0ce6d91
Merge branch 'master' of https://github.com/Microsoft/vscode-python
Jul 22, 2020
c8e67e6
Initial
Jul 22, 2020
94a3d61
Pylance activation tests
Jul 22, 2020
7518be3
Fix loc tests
Jul 22, 2020
32d3626
Add news
Jul 23, 2020
d7f106a
Fix test
Jul 23, 2020
07ea40f
Add reload on extension install
Jul 23, 2020
4b45562
Limit reload to once
Jul 24, 2020
b1a8b8b
Use command manager + add test
Jul 27, 2020
fc99438
Capilatization of `Language Server`
Jul 27, 2020
2f4c12f
Fix typos
Jul 27, 2020
b11463d
Prompt to reload
Jul 27, 2020
513021f
Typo
Jul 28, 2020
3a1c41c
Common Pylance check
Jul 28, 2020
c26a54f
Remove unused
Jul 28, 2020
adc3f3c
Remove duplicate telemetry
Jul 28, 2020
488b02c
formatting
Jul 28, 2020
88e7a2f
Remove switch
Jul 28, 2020
32f7cc3
Safer dispose
Jul 28, 2020
af97a75
Remove unnecessary ??
Jul 29, 2020
9e05807
Change order
Jul 29, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/1 Enhancements/13122.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Expose `Pylance` setting in `python.languageServer`. If [Pylance extension](https://marketplace.visualstudio.com/items?itemName=ms-python.vscode-pylance) is not installed, prompt user to install it.
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2319,6 +2319,7 @@
"type": "string",
"enum": [
"Jedi",
"Pylance",
MikhailArkhipov marked this conversation as resolved.
Show resolved Hide resolved
"Microsoft",
"None"
],
Expand Down
2 changes: 1 addition & 1 deletion package.nls.it.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,5 +27,5 @@
"python.snippet.launch.flask.label": "Python: Flask",
"python.snippet.launch.pyramid.label": "Python: Applicazione Pyramid",
"python.snippet.launch.attach.label": "Python: Allega",
"LanguageService.bannerLabelYes": "Sì, prenderò il sondaggio ora"
"ExtensionSurveyBanner.bannerLabelYes": "Sì, prenderò il sondaggio ora"
}
26 changes: 17 additions & 9 deletions package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,14 +109,12 @@
"python.snippet.launch.django.label": "Python: Django",
"python.snippet.launch.flask.label": "Python: Flask",
"python.snippet.launch.pyramid.label": "Python: Pyramid Application",
"LanguageService.proposePylanceMessage": "Try out a new faster, feature-rich language server for Python by Microsoft, Pylance! Install the extension now.",
"LanguageService.tryItNow": "Try it now",
"LanguageService.remindMeLater": "Remind me later",
"LanguageService.bannerLabelYes": "Yes, take survey now",
"LanguageService.bannerLabelNo": "No, thanks",
"LanguageService.lsFailedToStart": "We encountered an issue starting the Language Server. Reverting to the alternative, Jedi. Check the Python output panel for details.",
"LanguageService.lsFailedToDownload": "We encountered an issue downloading the Language Server. Reverting to the alternative, Jedi. Check the Python output panel for details.",
"LanguageService.lsFailedToExtract": "We encountered an issue extracting the Language Server. Reverting to the alternative, Jedi. Check the Python output panel for details.",
"Pylance.proposePylanceMessage": "Try out a new faster, feature-rich language server for Python by Microsoft, Pylance! Install the extension now.",
"Pylance.tryItNow": "Try it now",
"Pylance.remindMeLater": "Remind me later",
"Pylance.installPylanceMessage": "Pylance extension is not installed. Click Yes to open Pylance installation page.",
"Pylance.pylanceNotInstalledMessage": "Pylance extension is not installed.",
"Pylance.pylanceInstalledReloadPromptMessage": "Pylance extension is now installed. Reload window to activate?",
"DataScience.unknownMimeTypeFormat": "Mime type {0} is not currently supported.",
"DataScience.historyTitle": "Python Interactive",
"DataScience.dataExplorerTitle": "Data Viewer",
Expand Down Expand Up @@ -198,6 +196,8 @@
"OutputChannelNames.pythonTest": "Python Test Log",
"OutputChannelNames.jupyter": "Jupyter",
"ExtensionSurveyBanner.bannerMessage": "Can you please take 2 minutes to tell us how the Python extension is working for you?",
"ExtensionSurveyBanner.bannerLabelYes": "Yes, take survey now",
"ExtensionSurveyBanner.bannerLabelNo": "No, thanks",
"ExtensionSurveyBanner.maybeLater": "Maybe later",
"ExtensionChannels.installingInsidersMessage": "Installing Insiders... ",
"ExtensionChannels.installingStableMessage": "Installing Stable... ",
Expand Down Expand Up @@ -354,11 +354,19 @@
"Testing.configureTests": "Configure Test Framework",
"Testing.disableTests": "Disable Tests",
"Common.openOutputPanel": "Show output",
"LanguageService.lsFailedToStart": "We encountered an issue starting the language server. Reverting to Jedi language engine. Check the Python output panel for details.",
"LanguageService.lsFailedToDownload": "We encountered an issue downloading the language server. Reverting to Jedi language engine. Check the Python output panel for details.",
"LanguageService.lsFailedToExtract": "We encountered an issue extracting the language server. Reverting to Jedi language engine. Check the Python output panel for details.",
"LanguageService.downloadFailedOutputMessage": "Language server download failed",
"LanguageService.extractionFailedOutputMessage": "Language server extraction failed",
"LanguageService.extractionCompletedOutputMessage": "Language server download complete",
"LanguageService.extractionDoneOutputMessage": "done",
"LanguageService.reloadVSCodeIfSeachPathHasChanged": "Search paths have changed for this Python interpreter. Please reload the extension to ensure that the IntelliSense works correctly",
"LanguageService.startingJedi": "Starting Jedi Python language engine.",
"LanguageService.startingMicrosoft": "Starting Microsoft Python language server.",
"LanguageService.startingPylance": "Starting Pylance language server.",
"LanguageService.startingNone": "Editor support is inactive since language server is set to None.",
"LanguageService.reloadAfterLanguageServerChange": "Please reload the window switching between language servers.",
"AttachProcess.unsupportedOS": "Operating system '{0}' not supported.",
"AttachProcess.attachTitle": "Attach to process",
"AttachProcess.selectProcessPlaceholder": "Select the process to attach to",
Expand Down Expand Up @@ -564,5 +572,5 @@
"DataScience.interactiveWindowModeBannerTitle" : "Do you want to open a new Python Interactive window for this file? [More Information](command:workbench.action.openSettings?%5B%22python.dataScience.interactiveWindowMode%22%5D).",
"DataScience.interactiveWindowModeBannerSwitchYes" : "Yes",
"DataScience.interactiveWindowModeBannerSwitchAlways" : "Always",
"DataScience.interactiveWindowModeBannerSwitchNo" : "No"
"DataScience.interactiveWindowModeBannerSwitchNo" : "No"
}
4 changes: 2 additions & 2 deletions package.nls.nl.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@
"python.snippet.launch.flask.label": "Python: Flask",
"python.snippet.launch.pyramid.label": "Python: Pyramid-applicatie",
"python.snippet.launch.attach.label": "Python: aankoppelen",
"LanguageService.bannerLabelYes": "Ja, neem nu deel aan het onderzoek",
"LanguageService.bannerLabelNo": "Nee, bedankt",
"ExtensionSurveyBanner.bannerLabelYes": "Ja, neem nu deel aan het onderzoek",
"ExtensionSurveyBanner.bannerLabelNo": "Nee, bedankt",
"LanguageService.lsFailedToStart": "We zijn een probleem tegengekomen bij het starten van de language server. Aan het terugschakelen naar het alternatief, Jedi. Bekijk het weergavepaneel voor details.",
"LanguageService.lsFailedToDownload": "We zijn een probleem tegengekomen bij het downloaden van de language server. Aan het terugschakelen naar het alternatief, Jedi. Bekijk het weergavepaneel voor details.",
"LanguageService.lsFailedToExtract": "We zijn een probleem tegengekomen bij het uitpakken van de language server. Aan het terugschakelen naar het alternatief, Jedi. Bekijk het weergavepaneel voor details.",
Expand Down
13 changes: 11 additions & 2 deletions package.nls.ru.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,15 @@
"python.snippet.launch.flask.label": "Python: Flask",
"python.snippet.launch.pyramid.label": "Python: Приложение Pyramid",
"python.snippet.launch.attach.label": "Python: Подключить отладчик",
"LanguageService.bannerLabelYes": "Да, пройти опрос сейчас",
"LanguageService.bannerLabelNo": "Нет, спасибо"
"ExtensionSurveyBanner.bannerLabelYes": "Да, открыть опрос сейчас",
"ExtensionSurveyBanner.bannerLabelNo": "Нет, спасибо",
"ExtensionSurveyBanner.maybeLater": "Может быть, позже",
"ExtensionSurveyBanner.bannerMessage": "Не могли бы вы потратить пару минут на опрос о языковом сервере Pylance?",
"Pylance.proposePylanceMessage": "Попробуйте новый языковый сервер для Python от Microsoft: Pylance! Установите расширение Pylance.",
"Pylance.tryItNow": "Да, хочу",
"Pylance.remindMeLater": "Напомните позже",
"Pylance.installPylanceMessage": "Расширение Pylance не установлено. Нажмите Да чтобы открыть страницу установки Pylance.",
"Pylance.pylanceNotInstalledMessage": "Расширение Pylance не установлено.",
"Pylance.pylanceInstalledReloadPromptMessage": "Расширение Pylance установлено. Перезагрузить окно для его активации?",
"LanguageService.reloadAfterLanguageServerChange": "Пожалуйста, перезагрузите окно после смены типа языкового сервера."
}
4 changes: 2 additions & 2 deletions package.nls.zh-tw.json
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@
"python.command.python.analysis.clearCache.title": "清除模組分析快取",
"python.snippet.launch.module.default": "請輸入-模組-名稱",
"python.snippet.launch.attachpid.label": "Python: 使用處理程序 ID 連結",
"LanguageService.bannerLabelYes": "是,現在填寫調查",
"LanguageService.bannerLabelNo": "不了,謝謝",
"LanguageService.lsFailedToStart": "啟動語言伺服器時遇到問題。改回使用替代方案 \"Jedi\"。請檢查 Python 輸出面板以取得更多資訊。",
"LanguageService.lsFailedToDownload": "下載語言伺服器時遇到問題。改回使用替代方案 \"Jedi\"。請檢查 Python 輸出面板以取得更多資訊。",
"LanguageService.lsFailedToExtract": "擷取語言伺服器時遇到問題。改回使用替代方案 \"Jedi\"。請檢查 Python 輸出面板以取得更多資訊。",
Expand All @@ -59,6 +57,8 @@
"OutputChannelNames.pythonTest": "Python 測試記錄",
"OutputChannelNames.jupyter": "Jupyter",
"ExtensionSurveyBanner.bannerMessage": "請問您是否可以用兩分鐘的時間,告訴我們 Python 延伸模組在您環境中的運作情況?",
"ExtensionSurveyBanner.bannerLabelYes": "是,現在填寫調查",
"ExtensionSurveyBanner.bannerLabelNo": "不了,謝謝",
"ExtensionSurveyBanner.maybeLater": "等一下",
"ExtensionChannels.installingInsidersMessage": "正在安裝 Insiders... ",
"ExtensionChannels.installingStableMessage": "正在安裝穩定版... ",
Expand Down
Loading