Removed unused dependencies from the package and package-lock.json #16840 #18529
Conversation
…nd fetches the path of the interpreter.
…ing Multiple Files
There was a problem hiding this comment.
Hi @Harry-Hopkinson,
Thank you for your contribution. Please do not make changes for 2 different issues in the same PR, and instead open 2 separate PRs.
Please also undo the change to the sprint-planning.github-issues file.
| @@ -1,7 +1,8 @@ | |||
| // Copyright (c) Microsoft Corporation. All rights reserved. | |||
| // Licensed under the MIT License. | |||
|
|
|||
| // @ts-check | |||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | |||
There was a problem hiding this comment.
This was for stopping type checking errors
news/2 Fixes/18529.md
Outdated
| @@ -0,0 +1 @@ | |||
| Select the correct python path if no workspace path is available #18482 | |||
Harry-Hopkinson
changed the title
package.json
Outdated
| "uuid": "^3.3.2", | ||
| "vsce": "^2.6.6", | ||
| "vscode-debugadapter-testsupport": "^1.27.0", | ||
| "vscode-telemetry-extractor": "^1.9.5", |
There was a problem hiding this comment.
vscode-telemetry-extractor is still in use.
package.json
Outdated
| "uint64be": "^1.0.1", | ||
| "unicode": "^10.0.0", | ||
| "untildify": "^3.0.2", | ||
| "vscode-debugadapter": "^1.28.0", |
There was a problem hiding this comment.
vscode-debugadapter, vscode-debugprotocol and vscode-debugadapter-testsupport are the 3 components of the debug adapter (repo), which the extension actively uses to provide debugger support.
package.json
Outdated
| "uint64be": "^1.0.1", | ||
| "unicode": "^10.0.0", | ||
| "untildify": "^3.0.2", |
There was a problem hiding this comment.
untildify is still used by the extension.
|
I have merged the branches |
package-lock.json
Outdated
| "uint64be": "^1.0.1", | ||
| "unicode": "^10.0.0", |
There was a problem hiding this comment.
This package is used during the webpack bundling process, please re-add it to package.json and re-generate the package-lock.json.
|
Hi there, It seems like this PR ended in a stale state, despite the minimal changes. Please close this PR and open a new one with just the typescript-char and typescript-formatter changes + the news entry + the updated package-lock.json. |
|
New PR at #18608 |
Fix for #16840