From 69c4791728fdabb2bf9cd72fa41ee0094f0fa10a Mon Sep 17 00:00:00 2001 From: HeeJae Chang Date: Fri, 10 Mar 2023 12:46:10 -0800 Subject: [PATCH] fixed a bug where pylance not working on interactive window --- src/client/activation/languageClientMiddleware.ts | 2 +- src/client/activation/node/languageClientMiddleware.ts | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/client/activation/languageClientMiddleware.ts b/src/client/activation/languageClientMiddleware.ts index c34aadc80208..110d7461c615 100644 --- a/src/client/activation/languageClientMiddleware.ts +++ b/src/client/activation/languageClientMiddleware.ts @@ -42,7 +42,7 @@ export class LanguageClientMiddleware extends LanguageClientMiddlewareBase { ); } - private shouldCreateHidingMiddleware(jupyterDependencyManager: IJupyterExtensionDependencyManager): boolean { + protected shouldCreateHidingMiddleware(jupyterDependencyManager: IJupyterExtensionDependencyManager): boolean { return jupyterDependencyManager && jupyterDependencyManager.isJupyterExtensionInstalled; } diff --git a/src/client/activation/node/languageClientMiddleware.ts b/src/client/activation/node/languageClientMiddleware.ts index a749ee9e02b9..fbc534f17e1c 100644 --- a/src/client/activation/node/languageClientMiddleware.ts +++ b/src/client/activation/node/languageClientMiddleware.ts @@ -44,6 +44,11 @@ export class NodeLanguageClientMiddleware extends LanguageClientMiddleware { } } + // eslint-disable-next-line class-methods-use-this + protected shouldCreateHidingMiddleware(_: IJupyterExtensionDependencyManager): boolean { + return false; + } + protected async onExtensionChange(jupyterDependencyManager: IJupyterExtensionDependencyManager): Promise { if (jupyterDependencyManager && jupyterDependencyManager.isJupyterExtensionInstalled) { await this.lspNotebooksExperiment.onJupyterInstalled();