Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2815.md #2917

Closed
wants to merge 1 commit into from
Closed

Create 2815.md #2917

wants to merge 1 commit into from

Conversation

naflymim
Copy link

For #

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Unit tests & system/integration tests are added/updated
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

@brettcannon
Copy link
Member

I assume this is for #2872? If so then please add it to that PR.

@naflymim
Copy link
Author

Yes, This my first pull request. Can you please give me some instructions to create/attach a news file to a PR. Thank you.

Copy link
Author

@naflymim naflymim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

News file for the Issue #2872

@brettcannon
Copy link
Member

You need to go back to your git checkout where your branch for #2815 is, add the file, commit it to the branch for your PR, and then push the branch up to GitHub.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants