Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do best effort to download the experiments and use it in the very first session only #6597

Merged
merged 9 commits into from
Jul 18, 2019

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented Jul 15, 2019

For #6348

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@karrtikr karrtikr added the no-changelog No news entry required label Jul 15, 2019
@karrtikr karrtikr removed the no-changelog No news entry required label Jul 15, 2019
src/client/common/experiments.ts Outdated Show resolved Hide resolved
src/client/common/net/httpClient.ts Outdated Show resolved Hide resolved
src/client/common/experiments.ts Outdated Show resolved Hide resolved
src/client/common/experiments.ts Show resolved Hide resolved
src/client/common/experiments.ts Outdated Show resolved Hide resolved
src/client/common/experiments.ts Outdated Show resolved Hide resolved
src/client/common/nuget/nugetRepository.ts Outdated Show resolved Hide resolved
src/client/telemetry/index.ts Outdated Show resolved Hide resolved
src/client/telemetry/index.ts Outdated Show resolved Hide resolved
src/client/common/experiments.ts Outdated Show resolved Hide resolved
@karrtikr karrtikr force-pushed the besteffort branch 2 times, most recently from 807eaed to b5190d9 Compare July 17, 2019 23:42
Copy link

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor improvements and changes to error messages.
Mandatory change = updates to error message being logged.
Others are optional.

src/client/common/experiments.ts Outdated Show resolved Hide resolved
src/client/common/experiments.ts Outdated Show resolved Hide resolved
src/client/common/experiments.ts Outdated Show resolved Hide resolved
src/client/common/experiments.ts Show resolved Hide resolved
src/client/telemetry/index.ts Show resolved Hide resolved
@karrtikr karrtikr closed this Jul 18, 2019
@karrtikr karrtikr reopened this Jul 18, 2019
@karrtikr karrtikr merged commit 2d1a066 into microsoft:master Jul 18, 2019
@karrtikr karrtikr deleted the besteffort branch July 18, 2019 22:16
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants