Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --ci flag from install_ptvsd.py #7814

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

lightme16
Copy link

For #7698

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@msftclas
Copy link

msftclas commented Oct 8, 2019

CLA assistant check
All CLA requirements met.

@codecov-io
Copy link

codecov-io commented Oct 8, 2019

Codecov Report

Merging #7814 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7814   +/-   ##
=======================================
  Coverage   59.16%   59.16%           
=======================================
  Files         498      498           
  Lines       22254    22254           
  Branches     3578     3578           
=======================================
  Hits        13166    13166           
  Misses       8264     8264           
  Partials      824      824

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1536d8b...a58b979. Read the comment docs.

@lightme16
Copy link
Author

I can see that one test is failed due to

The agent: Azure Pipelines 21 lost communication with the server. Verify the machine is running and has a healthy network connection. For more information, see: https://go.microsoft.com/fwlink/?linkid=846610

Looks unrelated to this PR, it seems we need to restart the tests

@kimadeline kimadeline merged commit 5288cbd into microsoft:master Oct 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants