Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVN extension doesn't work with Remote-SSH #135

Closed
FractalBoy opened this issue May 5, 2019 · 3 comments
Closed

SVN extension doesn't work with Remote-SSH #135

FractalBoy opened this issue May 5, 2019 · 3 comments
Assignees

Comments

@FractalBoy
Copy link

  • VSCode Version: 1.34.0-insider
  • Local OS Version: Windows 10
  • Remote OS Version: CentOS 7
  • Remote Extension/Connection Type: SSH

Steps to Reproduce:

  1. Install the Subversion extension
  2. Try to use it (cd to a SVN directory)
  3. "There is no data provider that can provide view data" and ""Cannot find module 'original-fs'" in the developer's console.

Does this issue occur when you try this locally?: No
Does this issue occur when you try this locally and all extensions are disabled?: No

image

image

image

Note that git works fine and that the error in the developer's console does not show up locally.

I also opened this issue with the extension in case they need to make a change. JohnstonCode/svn-scm#561

@FractalBoy FractalBoy changed the title SVN extension doesn't work with Remote-sSH SVN extension doesn't work with Remote-SSH May 5, 2019
@Chuxel
Copy link
Member

Chuxel commented May 6, 2019

@FractalBoy Okay, looking at this, this may be due to this challenge with extensions that use native Node.js modules: https://code.visualstudio.com/api/advanced-topics/remote-extensions#using-native-node.js-modules

Assuming that is accurate, the extension will need to make some changes to accommodate remote development unfortunately.

//cc: @rebornix

@Chuxel
Copy link
Member

Chuxel commented May 6, 2019

@rebornix @FractalBoy Actually - I think in this particular case, this is a difference in how its accessing the "fs" node module... it's attempting to use original-fs to get at the underlying Node.js implementation's "fs" module. So technically not the same as the link above, but a similar underlying issue... Electron node verses standard node in the remote case.

This was introduced with this change: JohnstonCode/svn-scm#539

We'd looked at this extension before, but this update was published after we'd done the validation.

@Chuxel
Copy link
Member

Chuxel commented May 13, 2019

Closed via JohnstonCode/svn-scm#561 (comment)

@Chuxel Chuxel closed this as completed May 13, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants