Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User supplied project name wont apply if existing containers have an old name #2670

Closed
JacksonKearl opened this issue Mar 31, 2020 · 2 comments
Assignees
Labels
containers Issue in vscode-remote containers info-needed Issue requires more information from poster

Comments

@JacksonKearl
Copy link
Contributor

Ref #2645

Two directions:

  1. Create containers with prefix a by setting in .env file
  2. Close out connection, but don't remove containers.
  3. Launch vscode from terminal with env var set to b.
  4. Open in Contianer
  5. 🐛 the old containers seem to be reused (a prefix).

Similarly:

  1. Create containers with prefix a by setting in terminal
  2. Close out connection, but don't remove containers.
  3. Launch vscode from terminal with no env var set, but make a .env with prefix b set.
  4. Open in Contianer
  5. 🐛 the old containers seem to be reused (a prefix).

If I go into the container explorer and manually remove the shut down containers after closing the connection, the new env vars are respected.

@chrmarti chrmarti added this to the March 2020 milestone Apr 1, 2020
@chrmarti chrmarti added the containers Issue in vscode-remote containers label Apr 1, 2020
@chrmarti
Copy link
Contributor

chrmarti commented Apr 2, 2020

Both cases work for me as expected. Did you maybe export COMPOSE_PROJECT_NAME in your terminal, so the value suck around or something? Anything I might miss?

@chrmarti chrmarti added the info-needed Issue requires more information from poster label Apr 2, 2020
@chrmarti chrmarti removed this from the March 2020 milestone Apr 2, 2020
@JacksonKearl
Copy link
Contributor Author

Hm, I might have lost the terminal env var somewhere along the way. Cant reproduce anymore.

@vscodebot vscodebot bot locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

2 participants