Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Support multiple devcontainer.json files #7881

Closed
3 tasks done
chrmarti opened this issue Jan 23, 2023 · 3 comments
Closed
3 tasks done

Test: Support multiple devcontainer.json files #7881

chrmarti opened this issue Jan 23, 2023 · 3 comments
Labels
containers Issue in vscode-remote containers testplan-item
Milestone

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Jan 23, 2023

Refs: #7548

Complexity: 4

Create Issue


Supported locations: .devcontainer.json, .devcontainer/devcontainer.json and .devcontainer/*/devcontainer.json (note: only one level deep).

Test actions operating on a single devcontainer.json when there are multiple devcontainer.json in a workspace folder (Docker volumes are not supported yet):

  • Reopen in Container
  • Add to devcontainer.json (context menu on extensions in Extensions viewlet)
  • Configure Container Features
  • Open Folder in Container
  • Open Workspace in Container (config files are located relative to the .code-workspace file)
  • Open Container Configuration File

Some actions are also available while connected to a dev container, also test these while connected to a dev container. They should operate on the config of the current dev container.

On Windows also test with a workspace folder in WSL.

@connor4312
Copy link
Member

Couldn't quite test fully due to #7908, but I verified that it tried to use the right devcontainer.json in each case

@connor4312 connor4312 removed their assignment Jan 24, 2023
@brianbucketlist
Copy link

brianbucketlist commented Jan 25, 2023

I am having trouble with this, I keep getting a "select a container configuration template..." dialogue when trying any of the commands listed in this thread.

I'm on v0.266.1 running docker on wsl2 ubuntu 20.04 (also tried v0.269.0 from pre-release, same results)

note: previously the devcontainer config files in the django folder below were just in the .devcontainer folder and worked fine, and the node folder files are a basic node image

I have the following folder structure.
image

@jacobwoffenden
Copy link

@brianbucketlist I think this feature is in 0.272.0 onwards, I had to install Code Insiders and use the CLI to install the newer version. Current release of Code was incompatible.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers testplan-item
Projects
None yet
Development

No branches or pull requests

6 participants