Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization issues in port names #47

Closed
gcampbell-msft opened this issue Oct 4, 2022 · 5 comments
Closed

Localization issues in port names #47

gcampbell-msft opened this issue Oct 4, 2022 · 5 comments
Labels
bug Something isn't working external-bug This issue is a bug caused by an external package fixed-pending-release Fix is merged and will be included in the next release.

Comments

@gcampbell-msft
Copy link
Contributor

Type: Bug Report

Multiple people have reported issues with characters showing incorrectly due to localization issues.

This is due to an issue in one of our dependencies (an external bug).

#36 #29 #13

External issues and PR's here: serialport/bindings-cpp#63, serialport/node-serialport#2502
@gcampbell-msft gcampbell-msft added bug Something isn't working external-bug This issue is a bug caused by an external package labels Oct 4, 2022
@github-actions github-actions bot added the triage label Oct 4, 2022
This was referenced Oct 4, 2022
Closed
Closed
Closed
@gcampbell-msft
Copy link
Contributor Author

Hi all, this should be fixed in the most recent pre-release of the extension, please try it out and let us know!

Thanks.

@SmejkalJakub
@xiaguangbo
@Aeldit

@gcampbell-msft gcampbell-msft added fixed-pending-release Fix is merged and will be included in the next release. and removed fixed-pending-release Fix is merged and will be included in the next release. labels Nov 28, 2022
@SmejkalJakub
Copy link

Czech special characters work great, thank you for the fix.

image

@gcampbell-msft gcampbell-msft added the fixed-pending-release Fix is merged and will be included in the next release. label Nov 28, 2022
@xiaguangbo
Copy link

The port name Chinese displayed is OK, thanks

image

@benmcmorran
Copy link
Member

This issue is fixed in version 0.6.0 of the extension, which is now available in the VS Code Marketplace. Thanks again for your feedback!

@Aeldit
Copy link

Aeldit commented Nov 30, 2022

I'm sorry I can't test it before a while, but I'll let you know if it works as soon as I try it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working external-bug This issue is a bug caused by an external package fixed-pending-release Fix is merged and will be included in the next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@benmcmorran @SmejkalJakub @Aeldit @gcampbell-msft @xiaguangbo