Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Spell checking is not working behind proxy #16

Closed
zminic opened this issue Feb 19, 2016 · 9 comments
Closed

Spell checking is not working behind proxy #16

zminic opened this issue Feb 19, 2016 · 9 comments

Comments

@zminic
Copy link

zminic commented Feb 19, 2016

Although vscode works behind proxy normally spell checker is unable to display corrections when behind proxy.

@seanmcbreen
Copy link
Contributor

This unfortunately is true - I've added an enhancement label for this but for now have no immediate plans to fix this sorry 😢

Sean

@markusmauch
Copy link

I'd really love to see this, too... At the moment the extension is useless for us.

@aaroncalderon
Copy link

aaroncalderon commented Jul 11, 2016

@zminic Hi, what are your symthoms?

  • Do you get the words underlined as spelling errors but cannot get the correction suggestions? or
  • Do you not get anything at all?

Becaue I just updated to vscode 1.3 shortly after installing the extension, and I do not recall if the extension had worked before or not. Then, I am also behind a proxy, so I'm not sure if I am experiencing your issue or the extension does not work with the new version of vscode.

Thanks.
P.S. I'm shure that you can tell by my coment above that I need this extension, like really BAD.

@zminic
Copy link
Author

zminic commented Jul 14, 2016

@aaroncalderon Hi,

When behind proxy I didn't get anything at all.

I tried again with newest versions and problem seems to remain.

@seanmcbreen
Copy link
Contributor

Hi unfortunately the checker does not today support proxys it calls the service directly. There is a local spell checker available (has a few less features) otherwise I'm open to a pull request :)

@zminic
Copy link
Author

zminic commented Jul 14, 2016

Hi, I have checked out how this could be implemented and came to conclusion that teacher npm package uses "request" library to perform requests. It seems that they use outdated version (or a fork), and in current version "request" library allows to specify proxy via environment variables. If they update request library then this issue will be fixed, probably readme will need to be updated.

I have opened an issue in teacher repository.

@awellock
Copy link

Thanks for tracking that down @zminic! I am hoping that this get fixed quickly this is a super useful extension when it works.

@awellock
Copy link

Wanted to make everyone aware of the good work @zminic is doing for those of us that can not spell. enable proxy. Thanks again!

@seanmcbreen
Copy link
Contributor

This extension has had a large number of stability issues based on the availability of the underlying service. Today I published an update which points users to another extension for Spell Checking.

I'm closing the majority of issues as development on the extension has stopped. Sorry for any inconvenience this caused anyone, the good news is that there are better options out there now that don't require the service.

Sean

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants