From ae5078f4433d12cb2a2edb24d6f2705313126f03 Mon Sep 17 00:00:00 2001 From: Martin Aeschlimann Date: Fri, 11 Jan 2019 15:58:43 +0100 Subject: [PATCH] Breadcrumb for "out of workspace" files is bad. Fixes #64429 --- src/vs/workbench/browser/parts/editor/breadcrumbsModel.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/browser/parts/editor/breadcrumbsModel.ts b/src/vs/workbench/browser/parts/editor/breadcrumbsModel.ts index 1e1de8c7dca1a..9ef5e5681faca 100644 --- a/src/vs/workbench/browser/parts/editor/breadcrumbsModel.ts +++ b/src/vs/workbench/browser/parts/editor/breadcrumbsModel.ts @@ -108,13 +108,16 @@ export class EditorBreadcrumbsModel { folder: workspaceService.getWorkspaceFolder(uri), path: [] }; - while (uri.path !== '/') { if (info.folder && isEqual(info.folder.uri, uri)) { break; } info.path.unshift(new FileElement(uri, info.path.length === 0 ? FileKind.FILE : FileKind.FOLDER)); + let prevPathLength = uri.path.length; uri = dirname(uri); + if (uri.path.length === prevPathLength) { + break; + } } if (info.folder && workspaceService.getWorkbenchState() === WorkbenchState.WORKSPACE) {