Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Encoding overhaul and web support #102589

Closed
3 tasks done
bpasero opened this issue Jul 15, 2020 · 0 comments
Closed
3 tasks done

Test: Encoding overhaul and web support #102589

bpasero opened this issue Jul 15, 2020 · 0 comments

Comments

@bpasero
Copy link
Member

bpasero commented Jul 15, 2020

Refs: #79275

Complexity: 3

Create Issue


This milestone encoding support landed for web. This was possible by depending on iconv-lite-umd, a webpacked version of iconv-lite.

Note: Unless files.autoGuessEncoding: true, the encoding for a file will always be the value of the files.encoding setting (UTF-8 by default) unless the file has a UTF-8 or UTF-16 byte-order-mark for identification. And even when guessing is enabled, it may result in wrong guesses or no guesses at all.

Verify:

  • you can use
  • for text files you see an entry in the status bar that shows the encoding of the file
  • you can reopen the file with a different encoding ("Reopen with Encoding")
  • you can change the encoding of the file ("Save with Encoding")
  • UTF-8 with BOM, UTF-16LE and UTF-16BE put a byte-order-mark in the beginning (use Hex Editor extension to verify)
  • you can change files.encoding and from then on files will use the configured encoding when reading and writing
  • you can enable files.autoGuessEncoding: true and the encoding will be guessed from the contents (you can use this file to verify CP1252)
@bpasero bpasero added this to the July 2020 milestone Jul 15, 2020
@bpasero bpasero changed the title Encoding overhaul Test: Encoding overhaul Jul 15, 2020
@bpasero bpasero changed the title Test: Encoding overhaul Test: Encoding overhaul and web support Jul 15, 2020
@isidorn isidorn removed their assignment Aug 4, 2020
@alexdima alexdima removed their assignment Aug 4, 2020
@sandy081 sandy081 removed their assignment Aug 4, 2020
@sandy081 sandy081 closed this as completed Aug 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants