Extension API: QuickPick fuzzy search not finding results

[svsool]

Hi,

I use QuickPick component for opening daily notes in my extension.

Example:

When I type -2d or -2 d I expect -2 days | Friday, July 24, 2020 Exists (see screenshot above) to appear in the results, but I see this instead:

Sorting is also wrong as -25 days item comes last in the results. In the order I provide it to QuickPick -25 comes before -172, -235, -263. Is it configurable?

Another example:

When I type +m I expect all Mondays with leading +n days to appear from previous screenshot, but I see this instead:

What could be the problem with it or am I missing something?

Thanks!

[bpasero]

/duplicate #27317

[bpasero]

@svsool Maybe I closed too soon, can you give a minimal code snippet for me to run an extension with this picker? Thanks

[svsool]

Sure thing.

For repro purpose I modified "Open daily note" command to not rely on disk and render all results from past / next 2 years statically.

1. Please clone this repo https://github.com/svsool/vscode-memo and checkout quickpick-bug branch
2. Run yarn && code .
3. Then F5 to run extension host
4. Open any workspace
5. Execute "Open daily note" command from the command palette
6. Input "+m" vs "Monday" to see the difference in results, also "-m" finds nothing for instance where all Mondays with leading "-n days" expected

[bpasero]

Thanks, I can reproduce. I wonder if this possibly could be a duplicate of #34088

However, I am not entirely sure why for example I can type "fr august" and it returns results:

Since the quick pick implementation was done by @chrmarti I would like to confirm with him and then we can close as duplicate. Maybe there is a rule in place that treats non-word characters such as - different.

[svsool]

Thanks, I can reproduce. I wonder if this possibly could be a duplicate of #34088

However, I am not entirely sure why for example I can type "fr august" and it returns results:

Since the quick pick implementation was done by @chrmarti I would like to confirm with him and then we can close as duplicate. Maybe there is a rule in place that treats non-word characters such as - different.

What is also a bit weird is that there should be more than two Fridays in August, but it shows only two of them. I can see all Fridays when input is empty just by scrolling through +/- days around today, but not when the input has "fr august". I'd expect it to show all Fridays from every August, there should be around 4 August months to choose from because in this example range spans over +/- 2 years from now.

For instance, these two Fridays (I believe) should be shown when "fr august" typed as well:

[chrmarti]

Using matchesFuzzyCodiconAware() from codicon.ts for matching and compareAnything() from comparers.ts for sorting. @bpasero Should I switch to something else?

[bpasero]

@chrmarti you can change to fuzzyScorer.scoreFuzzy or fuzzyScorer.scoreFuzzy2. The former is used by quick open for files and the latter for quick open for symbols (and intellisense).

There is a risk of breaking muscle memory though. Related: #34088