defaultWorkerFactory.ts: deprecated require.toUrl() use

[bpasero]

The context is: #107437 and the deprecation of require.toUrl

I noticed 2 uses of require.toUrl that ideally we can replace with FileAccess.asFileUri and FileAccess.asBrowserUri:

vscode/src/vs/base/worker/defaultWorkerFactory.ts

Line 22 in 08c92c9

const workerMain = require.toUrl('./' + workerId);

vscode/src/vs/base/worker/defaultWorkerFactory.ts

Line 39 in 08c92c9

const workerBaseUrl = require.toUrl(myPath).slice(0, -myPath.length);

I would have done it but wasn't exactly sure, my guess would be to use the FileAccess.asBrowserUri variant here since we are in browser context.

[alexdima]

I'm a bit concerned about changing this, as this piece of code runs in the standalone editor too. So before this piece of code would go directly to the loader (which could be require.js and not our loader) and get back a string.

With the proposed change to use FileAccess.asBrowserUri, that string must now always go through our URI.parse and I believe URI.parse(str).toString() is not guaranteed to be equal to str.

[bpasero]

@alexdima understood and that is also the reason why I wanted to ask you about it since I was not so sure.

When I test from the vscode-file branch it seems to me the worker is coming up properly, at least on macOS:

So it may well be that things continue to work, either with file or vscode-file protocol because we load the worker in a browser context always.

I am fine leaving this use as is and maybe add a comment. I just wanted to bring this up to ensure this continues to work, even when we switch to the new base URL with vscode-file://vscode-app/... structure.

[bpasero]

I just added a comment explaining the use.