Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflowing decorations #110769

Closed
rebornix opened this issue Nov 17, 2020 · 2 comments
Closed

Overflowing decorations #110769

rebornix opened this issue Nov 17, 2020 · 2 comments
Assignees
Labels
under-discussion Issue is under discussion for relevance, priority, approach

Comments

@rebornix
Copy link
Member

Live Share extension currently uses the decoration API to render a name tag near the cursor

image

It works fine when the decoration is in the middle of the viewport (also when there are more than one line in the editor). When it's at the first line and top set to -1rem, the decoration will be cut off as the ViewLines/ScrollableElement has overflow: hidden.

LS work arounds this issue by rendering the name tag under the line when the cursor is on the first line. While this doesn't work for notebook as often the cell input only has one line (you can also reproduce this issue with Text Editor)

image

I'm wondering what's the best way to mitigate this issue, maybe some floating (overflowing) decorations? It sounds crazy so I'd like to know @alexdima 's suggestion on this.

@alexdima
Copy link
Member

The name appears to almost fit in the last screenshot.

Is it possible to do something pragmatic and just add padding to the editor when there is a live share session going on? (The editor option is literally called padding)

@alexdima alexdima added the under-discussion Issue is under discussion for relevance, priority, approach label Nov 17, 2020
@rebornix
Copy link
Member Author

Is it possible to do something pragmatic and just add padding to the editor when there is a live share session going on

It's an interesting idea. We can try this to simply add a new pixels more for editor padding (we are already using that but they are half em)

@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants