Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo of folder deletion brings back empty folder #111022

Closed
isidorn opened this issue Nov 20, 2020 · 6 comments
Closed

Undo of folder deletion brings back empty folder #111022

isidorn opened this issue Nov 20, 2020 · 6 comments
Assignees
Labels
file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach undo-redo Issues around undo/redo
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Nov 20, 2020

  1. Delete a folder with children in VS Code explorer
  2. Undo -> folder is brought back empty

This is due to the fact that we do not store all the contents of the folder in memory which can be very large. Which I think makes good sense.
As @bpasero points out: "I am not aware of any API for restoring from trash actually, but it would be a good solution"

Which I agree with. It would be cool if there was API to get things out from trash.

fyi @jrieken @alexdima

@isidorn isidorn added file-explorer Explorer widget issues under-discussion Issue is under discussion for relevance, priority, approach labels Nov 20, 2020
@isidorn isidorn self-assigned this Nov 20, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Nov 24, 2020

Idea from Joh: To circumvent the "restore from trash" problem we could try to move/copy the file that's to be deleted to some tmp-folder

@JacksonKearl
Copy link
Contributor

JacksonKearl commented Aug 13, 2021

Being able to Ctrl+Z would be nice, but if it breaks the system-standard deleted resource recovery mechanism it's not worth it. I don't want people to delete something on accident, check the trash, not see it, and get worried.

As-is this screen seems sufficient for pointing them in the right direction:
image

Leaving open to revisit if an api comes to recover deleted items from Trash.

@ashok-arjun
Copy link

Is there a way to bring the deleted files back? I just deleted a folder accidentally and Ctrl+Z does not retrieve the files, instead only returns an emtpy folder.

Please help @JacksonKearl @isidorn

@JacksonKearl
Copy link
Contributor

@ashok-arjun the files should be in the trash/recycling bin if your platform supports that.

@ashok-arjun
Copy link

ashok-arjun commented Oct 22, 2021

@JacksonKearl Got it, thank you!

@vscodenpa
Copy link

We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding, and happy coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code under-discussion Issue is under discussion for relevance, priority, approach undo-redo Issues around undo/redo
Projects
None yet
Development

No branches or pull requests

5 participants