Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer to open a workspace from empty explorer #112730

Open
bpasero opened this issue Dec 17, 2020 · 20 comments
Open

Offer to open a workspace from empty explorer #112730

bpasero opened this issue Dec 17, 2020 · 20 comments
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues workbench-multiroot Multi-root (multiple folders) issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Dec 17, 2020

The empty explorer currently looks like this:

image

I see how we want to save space and not show a "Open Workspace" button below the "Open Folder" button, but I think we could maybe leverage @sandy081 work and show a button with a dropdown?

The way this could work is:

  • if you just click the button it is as today "Open Folder"
  • if you click the dropdown next to it, you can also pick "Open Workspace"

If we go down this path I would think the wording should also be tweaked ("You have not yet opened a folder or workspace").

The UI component I am referring to is this:

image

@bpasero bpasero added workbench-multiroot Multi-root (multiple folders) issues file-explorer Explorer widget issues labels Dec 17, 2020
@isidorn isidorn added this to the January 2021 milestone Dec 17, 2020
@isidorn
Copy link
Contributor

isidorn commented Dec 17, 2020

This makes sense. However the reason against it is to not make this any more complicated for new users who have no clue what a workspace is.
Though I am open to try this out.

@sandy081 do you have a code pointer on how to use the new UI component?

@isidorn isidorn added the feature-request Request for new features or functionality label Dec 17, 2020
@bpasero
Copy link
Member Author

bpasero commented Dec 17, 2020

Yeah agree it is a bit more advanced and requires the user to have a *.code-workspace file, so it cannot be the default choice. But this is maybe a chance to get users more familar with workspaces all in all.

@sandy081
Copy link
Member

sandy081 commented Jan 4, 2021

You can use following action item to render an action with dropdown menu

export class ActionWithDropdownActionViewItem extends ActionViewItem {

To render a button you can use ButtonBar

addButtonWithDropdown(options: IButtonWithDropdownOptions): IButton {

@isidorn
Copy link
Contributor

isidorn commented Jan 15, 2021

Looking at the latest videos done by @burkeholland I am worried that this might just confuse new users additionally - what I already mentioned.

Maybe I bring this up in the UX meeting next week. @misolori
If we find a nice flow for the Create Folder, maybe that is part of the drop down as well.

@miguelsolorio
Copy link
Contributor

I'm still a fan of adding a split button for open folder and allowing extensions to contribute. The open folder can be: Open WSL/Codespace, Open Workspace, Clone Repo, etc. and would help reduce the amount of content that we currently have:

image

We can definitely bring it up in the UX sync this week.

@isidorn
Copy link
Contributor

isidorn commented Jan 22, 2021

Moving to next milestone to do it start of February to get user feedback

@isidorn isidorn modified the milestones: January 2021, February 2021 Jan 22, 2021
@miguelsolorio
Copy link
Contributor

Here's a quick mockup of what this could look like:

image

@isidorn
Copy link
Contributor

isidorn commented Jan 25, 2021

Looks cool!

@sandy081
Copy link
Member

In other places where I show this similar button (extensions), I also show the main action in the dropdown (from UX feedback I received). So, to be consistent, shall the dropdown also include main Open Folder action?

@bpasero
Copy link
Member Author

bpasero commented Jan 26, 2021

Looks good to me, agree that the primary action must be the first in the dropdown.

@isidorn
Copy link
Contributor

isidorn commented Jan 26, 2021

Agree. Also it is a bit funky that some of them have a ... and some do not. Intuitivly for me here we should not use the ...

@bpasero
Copy link
Member Author

bpasero commented Jan 26, 2021

They should all use a "..." at the end of the label if additional user input is required to perform the action which I think is true for all.

@isidorn
Copy link
Contributor

isidorn commented Jan 26, 2021

Yeah I know that pattern, I am just saying that for me personally in a clean welcome Explorer an Open Folder blue button looks better than the Open Folder...

@isidorn isidorn modified the milestones: February 2021, March 2021 Feb 24, 2021
@isidorn
Copy link
Contributor

isidorn commented Mar 16, 2021

In order to have this we would need support from the welcome views since the explorer is using the welcome view infrastructure.
The current syntax is command:ID, we could introduce a commands:ID1,ID2 syntax which would mean use the dropdown action.
@joaomoreno let me know what you think?

Anyways moving to On-Deck, since we will not have time for this this milestone.

@isidorn isidorn modified the milestones: March 2021, On Deck Mar 16, 2021
@miguelsolorio
Copy link
Contributor

FYI @eamodio

@joaomoreno
Copy link
Member

The current syntax is command:ID, we could introduce a commands:ID1,ID2 syntax which would mean use the dropdown action.

Oh man, we're growing this. Calling @jrieken for comments.

@bpasero
Copy link
Member Author

bpasero commented Mar 22, 2021

I really like the idea of allowing extensions to add a button with multiple choices because that could mean the overall number of visible buttons is reduced 👍

@jrieken
Copy link
Member

jrieken commented Mar 23, 2021

Oh man, we're growing this. Calling @jrieken for comments.

Should we just allow to reference a submenu?

@isidorn isidorn assigned JacksonKearl and unassigned isidorn Aug 12, 2021
@JacksonKearl
Copy link
Contributor

JacksonKearl commented Aug 13, 2021

Current semantics are that if the link is by itself on a line, it becomes a button. We could extend this to convert a line that is exclusively links to render as a dropdown button, with the first being the main title.

You have not yet opened a folder

[Open Folder](command:...) [Clone Repository...](command:...) [Connect to Codespace...](command:...) [Open Workspace...](command:...) 

Not sure what referencing a submenu would look like.

@miguelsolorio
Copy link
Contributor

Bringing this back to the surface because it's getting even more crowded:

CleanShot 2021-09-13 at 15 32 18@2x

@lramos15 lramos15 assigned lramos15 and unassigned JacksonKearl May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

8 participants