Extension host crash with extension ssh workspace folder on RHEL 6

[3b0b]

Issue Type: Bug

1. Install 1.53 Insider (my tests have been in portable mode)
2. Install either kelvin.sshfs or liximomo.remotefs
3. Configure an SSH connection to a RHEL 6 host
4. Add connection as workspace folder (crash may occur before this step with liximomo)

VS Code version: Code - Insiders 1.53.0-insider (c265dff, 2021-01-14T06:31:42.082Z)
OS version: Windows_NT x64 10.0.21292

Also reported SchoofsKelvin/vscode-sshfs#225 but at least at the time, he was unable to reproduce the crash, which I am guessing - since I only just discovered this was relevant - is because he was not trying to connect to a RHEL 6 host. As I mentioned in the other issue, I just discovered that the crash doesn't seem to happen when connecting to RHEL 7.3.

Both extensions work fine with the same connection configurations on 1.52.0-insider (dbbf707, 2020-12-10T17:20:40.435Z).

The crash seems to happen - I think - during the check for various potential configuration files in the workspace folder (.vscode, .git, .devcontainer, etc.), but I don't know whether those are causing it or if the timing might be coincidental.

I looked into using the official Remote SSH extension instead, but it doesn't seem to allow a remote workspace folder in the current session rather than the remote session taking over, and isn't compatible with the hosts I need to connect to anyhow.

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz (8 x 3408)
GPU Status	2d_canvas: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on protected_video_decode: unavailable_off rasterization: enabled skia_renderer: enabled_on video_decode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	31.93GB (13.94GB free)
Process Argv	--crash-reporter-id 8b95c023-eb1f-4528-9f8a-1680eaf9da0e
Screen Reader	no
VM	0%

Extensions (1)

Extension	Author (truncated)	Version
vscode-sshfs	Kel	1.19.1

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
openlogontheside:30221882
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30208929
wsl2prompt:30219162
vstry244:30244315
pythonvsdeb440:30224570
unusedpromptcf:30219165
folderexplorer:30219166
openfilemenu:30219168
pythonvsded773:30223139
vstes627:30244334
pythonvspyt859:30241729
core-portspanelcf:30233468

[alexdima]

@scriptninja Please continue the troubleshooting with @SchoofsKelvin via SchoofsKelvin/vscode-sshfs#225 . IMHO the crash of the extension host is caused (directly or indirectly) by something the extension is doing. I am happy to jump back into troubleshooting once we figure out that this is a crash caused by vscode core itself.

[SchoofsKelvin]

With the stable release of 1.53.0, this issue seems to have returned with multiple reports: SchoofsKelvin/vscode-sshfs#239. This also seems to be affecting users of a similar extension: liximomo/vscode-sftp#881.

I've noticed that there have been several internal version changes regarding OpenSSL/Electron/NodeJS, which might be part of the cause.

[3b0b]

Thanks to the efforts of people who understand node and electron better than I, it seems we've traced this as far as electron/electron#27673
Telling the server you're connecting to not to use Diffie-Hellman seems like it may not be possible for a lot of people, which I have the impression means their options are limited to staying on 1.52 until a fix both lands in Electron and gets pulled into vscode, or doing without the affected extensions. At any rate I thought it might be useful to connect this issue to that one.

[SchoofsKelvin]

I've quickly tested this in 1.54.0-insiders (3290f9a) and it seems like e4a082a did indeed fix it. I was able to use the affected diffie-hellman-group-exchange-sha256 without problem.