Adjust cell diff editor height based on viewport size

[Tyriar]

Testing #114969

Notice how the icon is blurry when clicking, that's how long it remains slow. Selection/editing in the diff editor is really slow as well, I believe this is because monaco is so large so it's creating so many dom elements.

[rebornix]

Good catch!

[Tyriar]

The inner monaco instance is now larger than the viewport. We're also getting into ugly scroll inside scroll territory here. I'd say the giant slow monaco instance is better than this:

[rebornix]

The inner monaco instance is now larger than the viewport. We're also getting into ugly scroll inside scroll territory here. I'd say the giant slow monaco instance is better than this:

This one is a difference case. Previously we always do a JSON format for the outputs and then render all lines, so when it has many lines, it would be more than one viewport, which is the same as now. The difference is now we limit the height to 1440px. Let's polish this in next iteration.

[Tyriar]

The difference is now we limit the height to 1440px.

@rebornix my monitor isn't that tall, the gif shows the scrollbar going out of view which is really bad. I'm pretty certain the majority of users are still on 1080p monitors, I suggest you base it off the viewport size instead of a magic number in this version.

[rebornix]

We now do this in notebook editor and the multi file diff editor does the same. We could look into adopting this approach for the DiffEditorWidgets in the notebook diff view.

[DonJayamanne]

We now do this in notebook editor and the m

Please can you clarify what you mean by this?
@rebornix /cc