Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scorer is not very good for matching on filenames #12095

Closed
octref opened this issue Sep 15, 2016 · 2 comments
Closed

Scorer is not very good for matching on filenames #12095

octref opened this issue Sep 15, 2016 · 2 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
October 2017

Comments

@octref
Copy link
Contributor

octref commented Sep 15, 2016

  • VSCode Version: 1.5.2
  • OS Version: OS X 10.11.6

image

The repo is Microsoft/vscode.
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Sep 16, 2016
@bpasero bpasero added this to the Backlog milestone Sep 16, 2016
@bpasero bpasero self-assigned this Sep 16, 2016
@bpasero
Copy link
Member

bpasero commented Sep 16, 2016

This is actually a corner case where our scoring is bad: Parts of the filename (explorerview.ts) end up matching on the folder instead of the file name. It is just bad luck that in this case explorerView.ts has parent folders that match more on the query compared to explorerViewModel.ts.

Overall we need to revisit our scoring functions and improve it to work better with files.

@bpasero bpasero changed the title Put exact match before others in Quick Open Scorer is not very good for matching on filenames Sep 16, 2016
@bpasero bpasero mentioned this issue Mar 27, 2017
Closed
@bpasero bpasero added workbench quick-pick Quick-pick widget issues labels Apr 7, 2017
@mjbvz mjbvz mentioned this issue Apr 12, 2017
Closed
@bpasero bpasero mentioned this issue May 26, 2017
Open
64 tasks
@bpasero
Copy link
Member

bpasero commented Oct 20, 2017

Fixed via 9d40f0c

@bpasero bpasero closed this as completed Oct 20, 2017
@bpasero bpasero modified the milestones: Backlog, October 2017 Oct 20, 2017
@mjbvz mjbvz added the verified Verification succeeded label Nov 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
October 2017
Development

No branches or pull requests
3 participants
@bpasero @octref @mjbvz