Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to avoid jumping to other places in Find All References? #12162

Closed
octref opened this issue Sep 16, 2016 · 8 comments
Closed

How to avoid jumping to other places in Find All References? #12162

octref opened this issue Sep 16, 2016 · 8 comments
Assignees
Labels
*caused-by-extension Issue identified to be caused by an extension

Comments

@octref
Copy link
Contributor

octref commented Sep 16, 2016

  • VSCode Version: 1.5.2
  • OS Version: OS X 10.11.6

jump

When I'm doing Find All References I hope I can just stay in the window. Jumping to random places loses me all context I've been working with.

I think Single click -> Show reference in the inline window, Double Click -> Go to the reference in file would be a better approach.

It also wouldn't hurt to add some decoration to the symbol that you are jumping to, and let it fade out after jumping there.

@jrieken jrieken added the info-needed Issue requires more information from poster label Sep 19, 2016
@jrieken
Copy link
Member

jrieken commented Sep 19, 2016

I think Single click -> Show reference in the inline window, Double Click -> Go to the reference in file would be a better approach.

That's how it works for me. A single click (or selection with arrow keys) preview the references in the peek window and a double click (or enter) jump to the reference. @octref Is there more that would allow me to reproduce? Any special single/double click configurations you are running with?

@octref
Copy link
Contributor Author

octref commented Sep 19, 2016

@jrieken
When the references are in the same file as the place where you open "Find All References".

For example, try it on FileStat in this line https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/common/explorerViewModel.ts#L21. Click the references under explorerViewModel (not the first few, the ones in the latter part).

@jrieken
Copy link
Member

jrieken commented Sep 20, 2016

Nope

sep-20-2016 09-33-32

@octref
Copy link
Contributor Author

octref commented Sep 20, 2016

The culprit is VSCodeVim. This behavior is gone when I disable it.
/cc @johnfn @rebornix

@rebornix
Copy link
Member

@octref I thought I was the only one who ran into this issue. Yes it's VSCodeVim indeed, we had a hard time tracking cursors.

@octref octref added *caused-by-extension Issue identified to be caused by an extension and removed info-needed Issue requires more information from poster labels Sep 20, 2016
@octref octref closed this as completed Sep 20, 2016
@octref
Copy link
Contributor Author

octref commented Sep 20, 2016

@rebornix Do we have an issue on VSCodeVim tracking it?

@rebornix
Copy link
Member

not yet, feel free to move this issue there or I can do it later.

@octref
Copy link
Contributor Author

octref commented Sep 20, 2016

Tracking in VSCodeVim/Vim#790

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*caused-by-extension Issue identified to be caused by an extension
Projects
None yet
Development

No branches or pull requests

3 participants