Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell moves up when output comes #121723

Open
jrieken opened this issue Apr 20, 2021 · 6 comments
Open

Cell moves up when output comes #121723

jrieken opened this issue Apr 20, 2021 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook-layout

Comments

@jrieken
Copy link
Member

jrieken commented Apr 20, 2021

  • see recording
  • no clear steps but I believe this happens when running a cell that isn't selected
Screen.Recording.2021-04-20.at.12.20.59.mov
@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug notebook labels Apr 21, 2021
@rebornix rebornix added this to the April 2021 milestone Apr 21, 2021
@rebornix
Copy link
Member

I have a feeling it's related to #121140 (comment)

@rebornix
Copy link
Member

Previously we try to make sure the visual view position of the selected cell not change at all, but in this particular scenario, the previous cell gets executed and the cell height grows after outputs are rendered. I pushed a change to improve this and the current behavior is

  • if the cell gets executed is visible in the viewport (its top border is in the viewport), then when it grows, the view won't scroll, not matter if the focused element is in the viewport or not
  • if the cell gets executed is partially hidden (the top border is hidden), then we will try to ensure the focus element's position won't change

@jrieken
Copy link
Member Author

jrieken commented Apr 29, 2021

Better, but not gone...

up.mov

@roblourens
Copy link
Member

I think this can be closed. Cell gets focused when executed and its scroll position is maintained

@roblourens roblourens removed this from the On Deck milestone May 23, 2022
@rebornix rebornix reopened this Jul 7, 2022
@gilles-zerah
Copy link

Note that Ctrl+Enter does not move the cell, from my experience, but naturally keeps the focus on the current cell.
I guess this is understandable since there is no change of focus contrary to Shift+Enter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug debt Code quality issues notebook-layout
Projects
None yet
Development

No branches or pull requests

8 participants
@roblourens @rebornix @jrieken @DonJayamanne @amunger @gilles-zerah @tanhakabir and others