Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An invalid icon in a terminal profile causes the whole label to not show #122369

Closed
alexr00 opened this issue Apr 27, 2021 · 0 comments
Closed

An invalid icon in a terminal profile causes the whole label to not show #122369

alexr00 opened this issue Apr 27, 2021 · 0 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-profiles terminal-tabs verified Verification succeeded
Milestone
April 2021

Comments

@alexr00
Copy link
Member

alexr00 commented Apr 27, 2021

While testing #120366, I set an icon to be nonsense:

	"terminal.integrated.profiles.windows": {
		"PowerShell": {
			"source": "PowerShell",
			"icon": "nonsense",
		}
	}

image
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal General terminal issues that don't fall under another label terminal-tabs terminal-profiles labels Apr 27, 2021
@Tyriar Tyriar added this to the April 2021 milestone Apr 27, 2021
@Tyriar Tyriar closed this as completed in c193a1c Apr 27, 2021
@alexr00 alexr00 added the verified Verification succeeded label Apr 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders terminal General terminal issues that don't fall under another label terminal-profiles terminal-tabs verified Verification succeeded
Projects
None yet
Milestone
April 2021
Development

No branches or pull requests
3 participants
@Tyriar @alexr00 and others