Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mouse selection not working #122653

Closed
isidorn opened this issue Apr 29, 2021 · 3 comments
Closed

Mouse selection not working #122653

isidorn opened this issue Apr 29, 2021 · 3 comments
Assignees
@rebornix @isidorn
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders ios-ipados verified Verification succeeded
Milestone
May 2021

Comments

@isidorn
Copy link
Contributor

isidorn commented Apr 29, 2021

As we noticed yesterday with latest iOS the external mouse selection does not seem work.
Creating issue so we have this on the radar.

Once we investigate we could create a WebKit issue
@isidorn isidorn added this to the May 2021 milestone Apr 29, 2021
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Apr 29, 2021
@bummoblizard bummoblizard mentioned this issue Apr 29, 2021
Closed
@isidorn
Copy link
Contributor Author

isidorn commented May 21, 2021

Okey, so the selection does work when the keyboard is not there and iPad is on a readonly field.
However as soon as the keyboard appears the mouse selection gets ignored.

@rebornix can you share a code pointer where we handle the mouse selection for the editor? So I investigate further

@isidorn
Copy link
Contributor Author

isidorn commented May 21, 2021

Safari was wrongly sending out a "pointermove" event instead of a "mousemove" event which was wrong. I have created https://bugs.webkit.org/show_bug.cgi?id=226082 on Safari side and pushed a wokraround on our side

@isidorn isidorn mentioned this issue May 21, 2021
Closed
@isidorn
Copy link
Contributor Author

isidorn commented May 21, 2021

For the record this fix is also needed for Chrome and Firefox, not only Safari.

@rebornix rebornix added the verified Verification succeeded label Jun 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders ios-ipados verified Verification succeeded
Projects
None yet
Milestone
May 2021
Development

No branches or pull requests
3 participants
@rebornix @isidorn and others