Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk-edit veto dialog talks about "Quit" always #123438

Closed
bpasero opened this issue May 10, 2021 · 1 comment
Closed

Bulk-edit veto dialog talks about "Quit" always #123438

bpasero opened this issue May 10, 2021 · 1 comment
Assignees
Labels
file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented May 10, 2021

From 9321b2f

The dialog here talks about "Quit", but a better way would be to check the shutdown reason from the event and update the wording accordingly, there can be:

  • quit
  • window close
  • window reload
  • workspace change ("Load")

const result = await this._dialogService.confirm({
message: localize('areYouSureQuiteBulkEdit', "Are you sure you want to quit? '{0}' is in progress.", label),
primaryButton: localize('quit', "Quit")
});

@isidorn isidorn added the file-explorer Explorer widget issues label May 10, 2021
@isidorn isidorn added this to the May 2021 milestone May 10, 2021
@isidorn
Copy link
Contributor

isidorn commented May 10, 2021

@bpasero good suggestion. I can look into this today.

@isidorn isidorn added the polish Cleanup and polish issue label May 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
file-explorer Explorer widget issues insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

3 participants
@bpasero @isidorn and others