Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: untitled notebooks #124844

Closed
3 tasks done
bpasero opened this issue May 28, 2021 · 2 comments
Closed
3 tasks done

Test: untitled notebooks #124844

bpasero opened this issue May 28, 2021 · 2 comments

Comments

@bpasero
Copy link
Member

bpasero commented May 28, 2021

Refs #121974

Complexity: 3

Authors: @bpasero, @jrieken, @rebornix

Create Issue


Untitled notebooks now leverage the file working copy workbench API and thus reuse most of the code that is also used by untitled text files.

Note: You can do this test with the ms-vscode.vscode-github-issue-notebooks extension.

Test:

  • use the command New GitHub Issue Notebook to open a new untitled notebook
  • verify this works for multiple untitled notebooks and each has a distinct label
  • verify the notebook get's dirty when you make changes
  • verify contents are restored after a restart (aka "hot exit")
  • verify that saving the notebook asks you for a file path and then replaces the editor with the saved file
  • verify you can close a dirty untitled notebook and get asked to save or revert
  • verify both save or revert work as expected when closing an untitled notebook
  • verify you can run code-insiders <path to non existing GH issue notebook> and that opens a new untitled notebook dirty that will save to the path once saved without asking
@roblourens
Copy link
Member

The github issues untitled notebook is dirty when it opens, I assume that's because it has this default content and is expected?

@gregvanl gregvanl removed their assignment Jun 2, 2021
@bpasero
Copy link
Member Author

bpasero commented Jun 2, 2021

@roblourens I would say so, that matches text files as well when they have initial contents.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants