Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag & drop with multiple folders, some of which are compact folders, always moves the leaf folders of the compact folders #125616

Closed
anthonyvdotbe opened this issue Jun 6, 2021 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@anthonyvdotbe
Copy link

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.57.0-insider fe1eafc
  • OS Version: Windows_NT x64 10.0.19043

Steps to Reproduce:

  1. create a folder structure as below
  2. open/close folders, such that projects shows sub1, sub2\subA, sub3
  3. select sub1 till sub3 and drag & drop them into `new-projects

Folder structure:

  • new-projects
  • projects
    • sub1
      • foo.txt
    • sub2
      • subA
        • bar.txt
    • sub3
      • baz.txt

Expected: the whole subtree of projects is moved into new-projects (note that this is the behavior when doing Cut/Paste instead of using drag & drop)
Actual: instead of moving sub2, its subdirectory subA is moved

Demo:
demo

@isidorn isidorn added file-explorer Explorer widget issues feature-request Request for new features or functionality labels Jun 7, 2021
@isidorn isidorn added this to the Backlog milestone Jun 7, 2021
@isidorn
Copy link
Contributor

isidorn commented Jun 7, 2021

So you would like the drag and drop of a compact folder to drag the upmost parent..

@anthonyvdotbe
Copy link
Author

Imho this is a bug, not a feature request, because when I want to move everything in projects into new-projects using DnD, the intuitive course of action (click first folder, Shift+click last folder, do DnD) has an unintuitive outcome. The presence of a compact folder is an accidental detail that shouldn't influence what's moved (even more so because I didn't explicitly select neither sub2 nor subA).

In fact, there's no way to do what I want with DnD at all because, as the demo below shows, even if I use Ctrl+click to explicitly select foo, DnD still attempts to move bar. So DnD doesn't honor the folders that were selected by the user & just copies the leaf folder no matter what.
demo

@anthonyvdotbe anthonyvdotbe changed the title Drag & drop with set of folders, some of which are subfolders, moves the subfolders Drag & drop with multiple folders, some of which are compact folders, always moves the leaf folders of the compact folders Jun 7, 2021
@anthonyvdotbe
Copy link
Author

@isidorn please consider classifying this as a bug. Imho the mere fact that DnD is inconsistent with cut/paste is sufficient argumentation to do so

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Jun 9, 2021
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants
@isidorn @anthonyvdotbe and others