Regular hover still shown when debugging

[alexdima]

Testing #127362

To be honest, I believe this is a VS Code core issue, but the TPI asks to create all issues here 🤷‍♂️ .

I think we normally hide the regular hover when doing debugging because of this overlap situation (cc @isidorn):

Kapture.2021-06-30.at.10.47.53.mp4

[isidorn]

@alexdima correct, that is the motivation why we hide the regular hover (I think you even did that original code like 7 years ago :)

However note that we only hide the regular hover when we think there is a debug hover on the file (it is part of the stack frame). Code pointer

Since this is a special notebook debugging case probably some of the checks are off. I leave this to @rchiodo for an initial investigation and I can help if needed, just let me know.

[roblourens]

@isidorn is it ok for debugEditorContribution to know about notebooks? I would make this line

vscode/src/vs/workbench/contrib/debug/browser/debugEditorContribution.ts

Line 283 in 07a0575

if (stackFrame && this.uriIdentityService.extUri.isEqual(model.uri, stackFrame.source.uri)) {

know how to parse a notebook cell URI to compare it to the editor model URI. Or, we can have a separate notebook contrib which does basically the same thing as this method.

[isidorn]

@roblourens that contribution has knowledge about the debug world and the editor world. So I think it is fine to add knowledge to notebooks as part of the "editor world".

[IanMatthewHuff]

Looks good to me. I just the the one hover and can get the language services hover with options key.