Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test Explorer] multiroot-workspace related issues #129444

Closed
connectdotz opened this issue Jul 26, 2021 · 3 comments
Closed

[Test Explorer] multiroot-workspace related issues #129444

connectdotz opened this issue Jul 26, 2021 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug testing Built-in testing support verified Verification succeeded
Milestone

Comments

@connectdotz
Copy link

connectdotz commented Jul 26, 2021

Issue Type: Bug

  1. the TestController displayed id instead of label in the explorer
  2. the test coverage did not display the overall (all workspaces) nor updated when the "active" workspace controller is changed
  3. not sure if this is intended, but how should we run the coverage profile?

VS Code version: Code - Insiders 1.59.0-insider (Universal) (955a1ac, 2021-07-26T05:12:43.446Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8700B CPU @ 3.20GHz (12 x 3200)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 4, 3
Memory (System) 32.00GB (2.79GB free)
Process Argv --enable-proposed-api Orta.vscode-jest --crash-reporter-id bb07f68d-9e6c-4982-a12f-528f81d06cb6
Screen Reader no
VM 0%
@connor4312
Copy link
Member

(1) was just fixed in 472a308. Test coverage is still a WIP, tracking under #123713.

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug testing Built-in testing support labels Jul 26, 2021
@connor4312 connor4312 added this to the July 2021 milestone Jul 26, 2021
@JacksonKearl
Copy link
Contributor

Steps please :)

@JacksonKearl JacksonKearl added the verification-steps-needed Steps to verify are needed for verification label Jul 29, 2021
@connor4312
Copy link
Member

  1. Use the test provider sample https://github.com/microsoft/vscode-extension-samples/tree/main/test-provider-sample
  2. Create a second controller and ctrl.items.add at least one test
  3. In the Test Explorer tree view, verify that you see both controllers with their correct labels

@connor4312 connor4312 removed the verification-steps-needed Steps to verify are needed for verification label Jul 29, 2021
@roblourens roblourens added the verified Verification succeeded label Jul 29, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug testing Built-in testing support verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants