Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Minimum width for VS Code status bar icon #13168

Closed
jamarw opened this issue Oct 3, 2016 · 5 comments
Closed

Question: Minimum width for VS Code status bar icon #13168

jamarw opened this issue Oct 3, 2016 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality *question Issue represents a question, should be posted to StackOverflow (VS Code)
Milestone

Comments

@jamarw
Copy link

jamarw commented Oct 3, 2016

  • VSCode Version: 1.5.3
  • OS Version: Windows 10 Enterprise (10.0.14393 Build 14393)

Steps to Reproduce:

  1. Create a typescript file in VS Code and a function to update the StatusBarItem
    Example:
function uiBold() {
        let statusBarItem: vscode.StatusBarItem;
        statusBarItem = vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Left);
        statusBarItem.text = "$(bold) Bold";
        statusBarItem.color = "black";
        statusBarItem.show()
        statusBarItem.command = "extension.formatBold";
}
  1. Create a new status bar item using the bold or italic Octicon icons [statusBarItem.text = "$(bold) Bold";]
  2. Open the file in debug mode/Extension Development Host] and run the command to launch the function
  3. Text (Bold) will render but icon will not.

Expected results
Using the code above, change the bold icon to pencil or gear and run step 3. Both the icon and text will show.

Question
Is there a minimum width required for VS Code status bar icons? I've tried a few and the ones that do not work are 10px or smaller in width (<svg width="10px"). Icons that I have tested that are 14px or larger work just fine.

Thanks and please let me know if you need any additional details or if you'd like me to share the ts files for the extension I'm developing.

@Tyriar Tyriar added *question Issue represents a question, should be posted to StackOverflow (VS Code) api labels Oct 3, 2016
@jamarw
Copy link
Author

jamarw commented Oct 25, 2016

Hi @jrieken , just checking in to see if there's any updates on this. Looping in the PM I'm working with on this project. Thanks

CC: @meganbradley

@jrieken
Copy link
Member

jrieken commented Oct 25, 2016

Sorry, no update yet. I also don't know if a min width is the best way going forward. Since everyone is biased towards her/his extension everyone is likely assigning a large min width.

Adding @stevencl and @bpasero that are in charge of the actual status bar implementation and design.

@jrieken jrieken added workbench and removed api labels Oct 25, 2016
@bpasero bpasero added the feature-request Request for new features or functionality label Oct 25, 2016
@bpasero bpasero added this to the Backlog milestone Oct 25, 2016
@bpasero
Copy link
Member

bpasero commented Oct 27, 2016

@jrieken I do not understand this issue. the problem is that the user tries to use an icon which does not exist in our version of octicon. We ship with 3.1.0 and bold seems only to be added in 3.2.0. I think we should eventually just update to latest to avoid this confusion.

@jrieken
Copy link
Member

jrieken commented Oct 27, 2016

Yeah - I didn't read further than minimum width. Closing this as dupe of #10455

@jrieken jrieken closed this as completed Oct 27, 2016
@jrieken jrieken added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 27, 2016
@jamarw
Copy link
Author

jamarw commented Oct 27, 2016

Thanks all for the help. I'll check the other issue for status.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality *question Issue represents a question, should be posted to StackOverflow (VS Code)
Projects
None yet
Development

No branches or pull requests

5 participants