Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks - Creating new notebook taking a long time #134526

Closed
claudiaregio opened this issue Oct 6, 2021 · 12 comments
Closed

Notebooks - Creating new notebook taking a long time #134526

claudiaregio opened this issue Oct 6, 2021 · 12 comments
Assignees
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues important Issue identified as high-priority info-needed Issue requires more information from poster notebook-perf

Comments

@claudiaregio
Copy link

  • VS Code Version: 1.61.0-insider
  • OS Version: Windows

I was screen recording for a different reason and a new notebook was taking a long time to open.

notebook load time long

Grabbed the logs and it was a bit faster this second time around but still slower than anticipated
Long Notebook Load Time.zip

@claudiaregio claudiaregio added freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues notebook labels Oct 6, 2021
@DonJayamanne
Copy link
Contributor

Is it fast with screen recording turned off. That's what @tanhakabir reported

@claudiaregio
Copy link
Author

It's a little bit faster with screen recording off but not by much, I attached the logs it still took quite a bit longer than I thought it would

@claudiaregio
Copy link
Author

@rebornix
Copy link
Member

rebornix commented Oct 6, 2021

image

Here is what I saw with the new log collected
CPU-20211006T211608.779Z.cpuprofile.txt

@deepak1556 do you find this somehow familiar? I'm not sure if it's simply because the CPU/Disk is busy or node's read file can be blocking.

@rebornix rebornix added the info-needed Issue requires more information from poster label Oct 6, 2021
@claudiaregio
Copy link
Author

@deepak1556
Copy link
Collaborator

Module.require is a blocking operation generally, looking at the attached profiles only read operations from .vscode-insiders/extensions are terribly slow. One of the profiles contain the Module.require for the main application and they are no affected, so this is going based of it.

@rebornix To quick check if something is not wrong at the system level, you can write a simple node script that does a require of the extension files and generate a profile with the following steps,

1) node --prof test-require-vscode-extensions.js
2) The above step on completion will generate a file of the format `isolate-0xnnnnnnnnnnnn-v8.log` in the current directory
3) node --prof-process isolate-0xnnnnnnnnnnnn-v8.log > processed.txt
4) `processed.txt` will now contain the symbolified sample stacks we can inspect

@tanhakabir tanhakabir reopened this Oct 14, 2021
@rebornix rebornix removed the notebook label Oct 21, 2021
@claudiaregio
Copy link
Author

Going to bump this again since I'm still experiencing it during golden scenario run

@claudiaregio claudiaregio added nb-golden important Issue identified as high-priority labels Oct 26, 2021
@roblourens
Copy link
Member

This looks like effectively 3.5s to activate the dotnet interactive extension, just to require its file. Does this still happen @claudiaregio? If so we can try the test that deepak suggests

@roblourens roblourens reopened this Nov 16, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues important Issue identified as high-priority info-needed Issue requires more information from poster notebook-perf
Projects
None yet
Development

No branches or pull requests

7 participants
@roblourens @rebornix @deepak1556 @DonJayamanne @tanhakabir @claudiaregio and others