Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting large files with the UI takes very long #134653

Open
BBiering opened this issue Oct 8, 2021 · 3 comments
Open

Deleting large files with the UI takes very long #134653

BBiering opened this issue Oct 8, 2021 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues
Milestone

Comments

@BBiering
Copy link

BBiering commented Oct 8, 2021

Issue Type: Performance Issue

Using the UI to delete large files with right clik + delete takes a usually long time (if it succeeds at all) compared to just running the linux command "rm filename"

VS Code version: Code 1.61.0 (ee8c7de, 2021-10-07T18:11:58.853Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No
Remote OS version: Linux x64 5.4.0-1052-gcp

System Info
Item Value
CPUs Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (6.14GB free)
Process Argv --crash-reporter-id d085b858-1b83-458d-a2a2-88f35f33475c
Screen Reader no
VM 0%
Item Value
Remote SSH: podimo_gcp
OS Linux x64 5.4.0-1052-gcp
CPUs Intel(R) Xeon(R) CPU @ 2.30GHz (4 x 2299)
Memory (System) 14.65GB (7.24GB free)
VM 0%
Extensions (20)
Extension Author (truncated) Version
vsc-material-theme Equ 33.2.0
vsc-material-theme-icons equ 1.2.2
jupyter-keymap ms- 1.0.0
remote-ssh ms- 0.65.8
remote-ssh-edit ms- 0.65.8
material-icon-theme PKi 4.10.0
vscode-icons vsc 11.6.0
material-theme zhu 3.13.2
vscode-edit-csv jan 0.6.3
git-graph mhu 1.30.0
vscode-docker ms- 1.17.0
python ms- 2021.10.1317843341
vscode-pylance ms- 2021.10.0
jupyter ms- 2021.9.1001312534
jupyter-keymap ms- 1.0.0
jupyter-renderers ms- 1.0.3
vscode-python-typehint njq 1.4.1
synthwave-vscode Rob 0.1.10
docker vsc 1.0.0
yaml vsc 1.0.0

(2 theme extensions excluded)

A/B Experiments
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551cf:30345471
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30358481
pythondataviewer:30285071
pythonvsuse255:30340121
vscod805cf:30301675
pythonvspyt200:30340761
binariesv615:30325510
vsccppwt:30378364
pythonvssor306:30344512
bridge0708:30335490
pygetstartedt2:30371810
dockerwalkthru:30377721
bridge0723:30353136
pythonrunftest32:30373476
pythonf5test824:30373475
javagetstartedt:30364666
pythonvspyt187:30373474
pydsgsc2:30361791
vsqsis200:30374795
vsaa593:30376534

@gjsjohnmurray
Copy link
Contributor

Maybe #101920

@JacksonKearl
Copy link
Contributor

We save a backup of the file for Cmd+Z on delete. What is the size of this file? We could maybe disable that for large files, or provide an option to disable it entirely. (#117621)

@JacksonKearl JacksonKearl added the info-needed Issue requires more information from poster label Oct 8, 2021
@divineyg
Copy link

divineyg commented Oct 12, 2021

+1

this is one of two major problems I have with large files ("large" being relative to network speed).

  • In my case, a 300MB file delete on a network that seems to perform at 10mb u/d wrecks the SSH connection and it's faster for me to close the app, restart it and then get all my terminals set back up
  • Any operation that inadvertently attempts to open a "large" file has similar results with the same destruction of workflow

All that I think is needed for both cases would be some configurable threshold where I can tell VSCode to warn me and allow an abort of whatever is about to happen. A secondary help would be some kind of way to abort what its doing (in the case that I thought it would be a good idea to open/delete/proceed with the large file).

This seems to be a glaring problem in an otherwise excellent tool.

@JacksonKearl JacksonKearl added the file-explorer Explorer widget issues label Oct 12, 2021
@JacksonKearl JacksonKearl added this to the On Deck milestone Oct 12, 2021
@JacksonKearl JacksonKearl added feature-request Request for new features or functionality and removed info-needed Issue requires more information from poster labels Oct 12, 2021
@lramos15 lramos15 assigned lramos15 and unassigned JacksonKearl May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues
Projects
None yet
Development

No branches or pull requests

5 participants