Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support win32 input mode in the terminal #135127

Closed
Tyriar opened this issue Oct 14, 2021 · 3 comments
Closed

Support win32 input mode in the terminal #135127

Tyriar opened this issue Oct 14, 2021 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code terminal Integrated terminal issues terminal-conpty Integrated terminal issues related to the ConPTY backend upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream windows VS Code on Windows issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 14, 2021

Newer versions of Conpty feature a win32 input mode which will cause it to always request this particular when it's support by conpty with:

CSI ? 9001 h

If the terminal supports it, it can then send full blown native input records encoded as strings, see docs here: https://github.com/microsoft/terminal/blob/main/doc/specs/%234999%20-%20Improved%20keyboard%20handling%20in%20Conpty.md

This would enable a whole bunch of keybindings that work in the older Windows terminals to work, for example:

  • Ctrl+Space
  • Shift+Enter
  • Ctrl+Break
  • Ctrl+Alt+?
  • Ctrl, Alt, Shift, (without another keydown/up)

Upstream issue: xtermjs/xterm.js#2357

@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal Integrated terminal issues windows VS Code on Windows issues terminal-conpty Integrated terminal issues related to the ConPTY backend upstream-issue-linked This is an upstream issue that has been reported upstream labels Oct 14, 2021
@Tyriar Tyriar added this to the Backlog milestone Oct 14, 2021
@Tyriar
Copy link
Member Author

Tyriar commented Dec 7, 2022

We support this via shell integration atm which is a cross platform solution. We could revisit this later if there's a good reason to do so.

@Tyriar Tyriar closed this as completed Dec 7, 2022
@Tyriar Tyriar added the *out-of-scope Posted issue is not in scope of VS Code label Dec 7, 2022
@rikrdo89
Copy link

rikrdo89 commented Sep 17, 2023

Could you please clarify if inline bash expansion is supported in the VScode bash/wsl integrated terminal? ctrl+alt+e works well in wsl outside of VScode but fails to expand a bash alias in VScode terminal.

@Tyriar
Copy link
Member Author

Tyriar commented Sep 18, 2023

@rikrdo89 if this is something other terminals do we should support it. Could you create an issue and point to some docs or provide steps on how to use it as I'm not familiar with that feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code terminal Integrated terminal issues terminal-conpty Integrated terminal issues related to the ConPTY backend upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

3 participants