Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Notebooks - Git Merge Conflicts Breaks Notebooks #136133

Closed
claudiaregio opened this issue Jun 25, 2021 · 6 comments
Closed

Native Notebooks - Git Merge Conflicts Breaks Notebooks #136133

claudiaregio opened this issue Jun 25, 2021 · 6 comments
Assignees
Labels
feature-request Request for new features or functionality notebook-ipynb

Comments

@claudiaregio
Copy link

Steps to reproduce:

  1. Create notebook
  2. Create merge conflict
  3. Save notebook and try to reopen in text editor

image

Had a quick chat with @rebornix and he believes following nbdime for this solution is a good start

https://nbdime.readthedocs.io/en/latest/cli.html#merging
https://nbdime.readthedocs.io/en/latest/merging.html

@dennisl68-castra
Copy link

dennisl68-castra commented Jul 14, 2021

As far as I know, the ordinary git diff tools only handles plain text and not structured data (well, they do, but they are totally unaware if the result is a legitim structure).

Or maybe gron is a better tool as it handles JSON generically...
jsondiff: diff JSON in Git using gron
Cool json git diff command

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Oct 18, 2021

@claudiaregio Are you still running into this issue. If yes please could you create an issue on VS COde repo as jupyter extension doesn't own this feature.

@gro1m
Copy link

gro1m commented Jan 27, 2022

As far as I know, the ordinary git diff tools only handles plain text and not structured data (well, they do, but they are totally unaware if the result is a legitim structure).

Or maybe gron is a better tool as it handles JSON generically... jsondiff: diff JSON in Git using gron Cool json git diff command

Yeah, but for example a "simple" editor like vim can handle this :)

@rebornix rebornix added notebook-ipynb feature-request Request for new features or functionality labels Dec 6, 2022
@vscodenpa vscodenpa added this to the Backlog Candidates milestone Dec 6, 2022
@vscodenpa
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality notebook-ipynb
Projects
None yet
Development

No branches or pull requests

6 participants