Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM - Action button polish #136275

Closed
4 tasks done
lszomoru opened this issue Nov 2, 2021 · 8 comments
Closed
4 tasks done

SCM - Action button polish #136275

lszomoru opened this issue Nov 2, 2021 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Milestone

Comments

@lszomoru
Copy link
Member

lszomoru commented Nov 2, 2021

  • Left alignment is incorrect as the input field has a larger left margin
  • Sync icon should appear before the text to be consistent with the Publish button
  • Sync and Publish icon should not have a left margin so that the content is centred
  • Rows that contain the input field and button should not have a hover feedback

image

image

//cc @misolori

@lszomoru lszomoru added bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues labels Nov 2, 2021
@lszomoru lszomoru added this to the November 2021 milestone Nov 2, 2021
@lszomoru lszomoru self-assigned this Nov 2, 2021
@lszomoru
Copy link
Member Author

lszomoru commented Nov 2, 2021

image

image

@miguelsolorio
Copy link
Contributor

Beautiful!

@kimadeline
Copy link

When using VS Code 1.63.0-insider commit 0cc0904 I noticed the following:

  • the "Sync" button isn't as wide as the message text box
  • when resizing the panel to be at its minimum size the buttons overflow:

image

  • when clicking on the rows there is a selection outline; clicking on the message row focuses on the text box, but clicking on the button row doesn't select the button. Is it expected?
scm_button.mp4

@lramos15 lramos15 added the verification-found Issue verification failed label Dec 3, 2021
@lramos15
Copy link
Member

lramos15 commented Dec 3, 2021

Reopening as verification found based on @kimadeline's comments. Feel free to close and have those be separate polish items

@lramos15 lramos15 reopened this Dec 3, 2021
@lszomoru
Copy link
Member Author

lszomoru commented Dec 3, 2021

Thanks @lramos15. I will push this out to the next milestone.

@lszomoru lszomoru removed the verification-found Issue verification failed label Dec 3, 2021
@lszomoru lszomoru modified the milestones: November 2021, December 2021 Dec 3, 2021
@heartacker
Copy link
Contributor

hi, @lszomoru could you please add an option to git sync button

  1. sync by default
  2. sync with rebase
    like:
    Improving the default SCM user experience #135992 (comment)
    image

and if

"git.rebaseWhenSync": true

then the default button action will be sync change with rebase

@lszomoru
Copy link
Member Author

Closing this issue as it is scoped to the sync button overflow functionality. We have settled on the following:

Full label when there is enough space:
image

Trimmed label where there is not enough space:
image

@LinqLover
Copy link

Very nice, thank you!

@meganrogge meganrogge added the verified Verification succeeded label Jan 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

8 participants
@heartacker @lszomoru @lramos15 @meganrogge @miguelsolorio @LinqLover @kimadeline and others