Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webview find widget doesn't work in OSS builds #136476

Closed
mjbvz opened this issue Nov 5, 2021 · 3 comments
Closed

Webview find widget doesn't work in OSS builds #136476

mjbvz opened this issue Nov 5, 2021 · 3 comments
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member wont-fix

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 5, 2021 •
edited
Loading

Repro

  1. Using an OSS build
  2. Open the markdown preview and try triggering find

Bug
Nothing happens

Find works fine in insiders/stable
@mjbvz
Copy link
Collaborator Author

mjbvz commented Nov 5, 2021

Sounds like we need to backport the electron changes that enabled this back to the public electron repro

@deepak1556
Copy link
Collaborator

deepak1556 commented Nov 8, 2021 •
edited
Loading

Upstream PR never got forward electron/electron#28274 pending discussion with chromium https://bugs.chromium.org/p/chromium/issues/detail?id=1189789 , it is possible that change might not make into OSS electron anytime soon.

@rzhao271
Copy link
Contributor

rzhao271 commented Dec 5, 2022

Closing as wontfix because we're blocked on upstream.

@rzhao271 rzhao271 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2022
@rzhao271 rzhao271 added wont-fix bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member labels Dec 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member wont-fix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deepak1556 @rzhao271 @mjbvz