Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag style isn't applied to markdown cells #137399

Closed
roblourens opened this issue Nov 17, 2021 · 2 comments
Closed

Drag style isn't applied to markdown cells #137399

roblourens opened this issue Nov 17, 2021 · 2 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-dnd verified Verification succeeded
Milestone
November 2021

Comments

@roblourens
Copy link
Member

  • Drag a code cell, see the dragged cell becomes a little grayed out
  • Drag a markdown cell, see no change in style

From #131808 (comment)
@roblourens roblourens self-assigned this Nov 17, 2021
@roblourens roblourens added this to the November 2021 milestone Nov 17, 2021
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Nov 17, 2021
@roblourens
Copy link
Member Author

Can't just use cell decorations because if you start dragging in the webview, the code that adds DRAGGING_CLASS is not running, it's different code in the webview that drives the dragging.

@amunger
Copy link
Contributor

amunger commented Dec 2, 2021

It looks like the cell does go partially transparent when being moved, as intended, but I don't see a difference with the stable version. Is that expected?

@joyceerhl joyceerhl added the verified Verification succeeded label Dec 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders notebook-dnd verified Verification succeeded
Projects
None yet
Milestone
November 2021
Development

No branches or pull requests
5 participants
@roblourens @rebornix @amunger @joyceerhl and others