Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff view: output metadata change UX is confusing #137836

Closed
ronglums opened this issue Nov 24, 2021 · 3 comments
Closed

Diff view: output metadata change UX is confusing #137836

ronglums opened this issue Nov 24, 2021 · 3 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) notebook-diff ux User experience issues
Milestone
February 2022

Comments

@ronglums
Copy link

Version: 1.63.0-insider (user setup)
Commit: ed3018f
Date: 2021-11-23T05:33:39.595Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000

Steps to Reproduce:

  1. open this notebook in VS Code https://github.com/claudiaregio/data-science/blob/main/Titanic.ipynb
  2. "Run All" cells
  3. switch to the diff view for the notebooks file
  4. scroll down to this cell
    image

It's confusing that the two tables are highlighted in red and green colors, even though their content is identical. Also, the "Switch output rendering" button is hard to discover as it's on the far-right side.
@rebornix rebornix added notebook-diff ux User experience issues labels Dec 16, 2021
@minsa110
Copy link

minsa110 commented Jan 13, 2022 •
edited
Loading

Related: #135820

I also ran into this today while running the golden scenario

@greazer greazer added nb-golden bug Issue identified by VS Code Team member as probable bug and removed notebook-triage labels Jan 24, 2022
@greazer greazer added this to the February 2022 milestone Feb 4, 2022
@greazer
Copy link
Member

greazer commented Feb 4, 2022

I knew I saw this before. Closing #135820 in lieu of this one. I think Claudia may have run into this too.

@greazer
Copy link
Member

greazer commented Feb 4, 2022

Actually closing this one instead. #135820 is the original and contains much more detail.

@greazer greazer closed this as completed Feb 4, 2022
@greazer greazer added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 4, 2022
@greazer greazer mentioned this issue Feb 9, 2022
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) notebook-diff ux User experience issues
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
5 participants
@rebornix @minsa110 @greazer @ronglums and others