-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shell integration: Use command tracking as alternative child process tracking #139522
Comments
Blocked by supporting subshells |
Created the subshell issue #141343, instead of relying on sub-shell support, we could just say when the shell is not in the prompt, the terminal's busy. This is arguably better than the current child process support anyway as the terminal is doing something. Sub-shells are a problem as it would always be busy, but that's a problem that could be handled with #131343. Need to way the pros/cons for both ways. |
Ideas:
This should make the dirty indicator much more responsive as well. |
This is mainly a small performance improvement where we would be able to not poll for the process tree as much. |
We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our roadmap and issue reporting guidelines. Thanks for your understanding, and happy coding! |
Use command tracking to save running a process for whether the shell is dirty, similar to cwd tracking this will lead to more responsive UI and less work happening on update. https://github.com/microsoft/vscode/blob/a1bf964306d30a9bbccb404b1b653e5a02fe3052/src/vs/platform/terminal/node/childProcessMonitor.ts
The text was updated successfully, but these errors were encountered: