Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio Code Webview Resources not loading in the latest Insiders release #139544

Closed
heartacker opened this issue Dec 21, 2021 · 13 comments
Closed
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Milestone

Comments

@heartacker
Copy link
Contributor

Does this issue occur when all extensions are disabled?: Yes/No

版本: 1.64.0-insider (system setup)
提交: 807bf59
日期: 2021-12-20T07:18:13.749Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22523

mhutchie/vscode-git-graph#604 (comment)

and I believe there is something related to vscode-insiders.
I have two PC, and both of them have same problem within vscode-insider and both of them work well within vscode-stable
BTW, we could see the full view of git-graph and after some view-switching, git-graph crash randomly.
there is a screen-record gif:
git-graph
hope that will help to debug

@mhutchie
Copy link

I'm the author of the Git Graph extension.

The behaviour observed occurs when Visual Studio Code Insiders doesn't provided the necessary JavaScript & CSS resources that the extension requests when the Visual Studio Code Webview is loading / reloading. What you see in this screenshot is the base HTML of the Webview - as soon as the required Javascript and/or CSS are provided by Visual Studio Code, the interface would immediately be rendered as expected.

image

When the user first opens the Git Graph View (Webview), or it becomes visible again, the extension sets the HTML of the Webview. Based on the screen recording from @heartacker, it clearly indicates that the JavaScript & CSS resources that are requested by Git Graph do exist on the file system. There must be an issue introduced into Visual Studio Code Insiders 1.46 when Webviews are restored, where Visual Studio Code doesn't provide the requested resources.

I can't manage to replicate the same behaviour using the same Visual Studio Code Insider build, so this issue only affects some users in the latest Insiders build.

@Fuahi
Copy link

Fuahi commented Dec 26, 2021

image
same problem

please

版本: 1.64.0-insider (system setup)
提交: 7b9e5c3
日期: 2021-12-22T05:15:28.225Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 3, 2022

I can't reproduce this. If you are seeing this issue, please run Toggle Developer tools and share the logs from the developer tools console so we can investigate the issue

@mjbvz mjbvz added the info-needed Issue requires more information from poster label Jan 3, 2022
@heartacker
Copy link
Contributor Author

vscode-app-1641261558406.log
seem that there is no effective information when WebView crash

@bradlitterell

This comment has been minimized.

@heartacker
Copy link
Contributor Author

vscode-app-1641395653341.log
I have provided two log when git -graph crash
@mjbvz what can I do more now.

@heartacker
Copy link
Contributor Author

maybe same issue
shd101wyy/vscode-markdown-preview-enhanced#560

@heartacker
Copy link
Contributor Author

seems that this issue is disappeared
with the version

版本: 1.64.0-insider (system setup)
提交: 00f1ca4
日期: 2022-01-11T09:15:49.397Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22523

@heartacker
Copy link
Contributor Author

@mjbvz

@mjbvz
Copy link
Collaborator

mjbvz commented Jan 11, 2022

Thanks for testing. Fixed by #140351

@mjbvz mjbvz closed this as completed Jan 11, 2022
@mjbvz mjbvz added this to the January 2022 milestone Jan 11, 2022
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug webview Webview issues and removed info-needed Issue requires more information from poster labels Jan 11, 2022
@mjbvz mjbvz added the author-verification-requested Issues potentially verifiable by issue author label Jan 27, 2022
@mjbvz
Copy link
Collaborator

mjbvz commented Jan 29, 2022

@heartacker Can you please verify that this has been fixed in the latest insiders?

@heartacker
Copy link
Contributor Author

YES, It works well 👯

@roblourens roblourens added the verified Verification succeeded label Feb 1, 2022
@heartacker
Copy link
Contributor Author

image

this issue reappears;

版本: 1.65.0-insider (system setup)
提交: 8440b8f
日期: 2022-02-25T05:17:33.544Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.14393

@mjbvz

@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug verified Verification succeeded webview Webview issues
Projects
None yet
Development

No branches or pull requests

6 participants