Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell integration: Use our own custom sequences for shell integration #140514

Closed
Tyriar opened this issue Jan 11, 2022 · 2 comments
Closed

Shell integration: Use our own custom sequences for shell integration #140514

Tyriar opened this issue Jan 11, 2022 · 2 comments
Assignees
@Tyriar
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc.
Milestone
February 2022

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 11, 2022

See:
@Tyriar Tyriar added plan-item VS Code - planned item for upcoming terminal-shell-integration Shell integration, command decorations, etc. labels Jan 11, 2022
@Tyriar Tyriar added this to the January 2022 milestone Jan 11, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Jan 18, 2022

There's also OSC 9;9?

microsoft/terminal#8166

@Tyriar Tyriar modified the milestones: January 2022, February 2022 Jan 26, 2022
@Tyriar Tyriar added debt Code quality issues and removed plan-item VS Code - planned item for upcoming labels Jan 26, 2022
@Tyriar
Copy link
Member Author

Tyriar commented Feb 3, 2022 •
edited
Loading

Plan here is to move to our own custom sequences so we don't get confused by common ones used by other shell integration scripts, this will also allow us to experiment more with our own (like the pwsh command line one). We explicitly don't want to handle sequences from programs.

@Tyriar Tyriar changed the title Shell integration: Prefer OSC 7 over OSC 1337 for cwd sequence Shell integration: Use our own custom sequences for shell integration Feb 3, 2022
@Tyriar Tyriar mentioned this issue Feb 4, 2022
Closed
@Tyriar Tyriar closed this as completed in 160056a Feb 14, 2022
@Tyriar Tyriar mentioned this issue Mar 23, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders terminal-shell-integration Shell integration, command decorations, etc.
Projects
None yet
Milestone
February 2022
Development

No branches or pull requests
3 participants
@Tyriar @meganrogge and others