Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Completion Bracket Matching Issues #141550

Closed
hediet opened this issue Jan 26, 2022 · 1 comment
Closed

Inline Completion Bracket Matching Issues #141550

hediet opened this issue Jan 26, 2022 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug inline-completions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@hediet
Copy link
Member

hediet commented Jan 26, 2022

This works:
image

But this doesn't, but should:
image

@juihanamshet1
Copy link
Member

There was also this scenario in the original issue which I believe is related
Before:
https://user-images.githubusercontent.com/86270736/148269808-40ab52a7-80d1-4031-a7b6-64cce7ef5b47.png

After:
After I hit Tab, notnull would be accepted and the (x) would disappear.

@hediet hediet modified the milestones: February 2022, March 2022 Feb 24, 2022
@hediet hediet closed this as completed in 11e60eb Mar 2, 2022
@rzhao271 rzhao271 added the verified Verification succeeded label Mar 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug inline-completions insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@hediet @rzhao271 @juihanamshet1 and others